Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1132743004: PPC: New hydrogen instruction to reduce cost of growing an array on keyed stores. (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: New hydrogen instruction to reduce cost of growing an array on keyed stores. Port 3bce9c3afbe792167a54db49b16679289e0aea8f Original commit message: HMaybeGrowElements moves the situation where you actually have to grow into deferred code. This means crankshaft doesn't have to spill registers just to make the bounds comparison to see if it'll need to grow or not. It makes the growing case a bit more expensive, but reduces the cost of the general case. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/09ecf6cef7f24169ab74bac4c4c4f4459d3d4df4 Cr-Commit-Position: refs/heads/master@{#28372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -1 line) Patch
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-12 15:01:24 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-12 15:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132743004/1
5 years, 7 months ago (2015-05-12 15:06:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 15:42:48 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:42:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09ecf6cef7f24169ab74bac4c4c4f4459d3d4df4
Cr-Commit-Position: refs/heads/master@{#28372}

Powered by Google App Engine
This is Rietveld 408576698