Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1132723009: Ensure AndroidEduOwnerCheckCallback is called. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure AndroidEduOwnerCheckCallback is called. ChromiumApplication.AndroidEduOwnerCheckCallback() has a stub implementation that doesn't actually call the passed in callback. This fixes the stub to actually call the callback with a value of false, which fixes code that depends on this callback being called. BUG=489514 Committed: https://crrev.com/9fa908a165780d7c3ebb487219594eda7a17e447 Cr-Commit-Position: refs/heads/master@{#330467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-19 01:01:20 UTC) #2
aruslan
lgtm
5 years, 7 months ago (2015-05-19 01:05:30 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 7 months ago (2015-05-19 01:07:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132723009/1
5 years, 7 months ago (2015-05-19 01:08:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 01:41:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 01:42:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fa908a165780d7c3ebb487219594eda7a17e447
Cr-Commit-Position: refs/heads/master@{#330467}

Powered by Google App Engine
This is Rietveld 408576698