Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5257)

Unified Diff: chromecast/chromecast.gyp

Issue 1132663004: Chromecast: adds Android implementation of CastSysInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/chromecast.gyp
diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp
index ed8261946da5e80e41803afbee1fc4a7099238a4..722dc48a3e4f8a8fa09be9df75d6ed78daf979ea 100644
--- a/chromecast/chromecast.gyp
+++ b/chromecast/chromecast.gyp
@@ -354,7 +354,7 @@
'base/cast_sys_info_dummy.h',
],
'conditions': [
- ['chromecast_branding!="Chrome"', {
+ ['chromecast_branding!="Chrome" and OS!="android"', {
'sources': [
'base/cast_sys_info_util_simple.cc',
],
@@ -375,10 +375,10 @@
'message': 'Generating version header file: <@(_outputs)',
'inputs': [
'<(version_path)',
- 'common/version.h.in',
+ 'base/version.h.in',
],
'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/chromecast/common/version.h',
+ '<(SHARED_INTERMEDIATE_DIR)/chromecast/base/version.h',
],
'action': [
'python',
@@ -392,7 +392,7 @@
'-e', 'CAST_BUILD_RELEASE="<!(if test -f <(cast_build_release); then cat <(cast_build_release); else echo eng.${USER}; fi)"',
'-e', 'CAST_IS_DEBUG_BUILD=1 if "<(CONFIGURATION_NAME)" == "Debug" or <(cast_is_debug_build) == 1 else 0',
'-e', 'CAST_PRODUCT_TYPE=<(cast_product_type)',
- 'common/version.h.in',
+ 'base/version.h.in',
'<@(_outputs)',
],
'includes': [
@@ -446,6 +446,8 @@
'../breakpad/src',
],
'sources': [
+ 'base/cast_sys_info_android.cc',
+ 'base/cast_sys_info_android.h',
'android/cast_jni_registrar.cc',
'android/cast_jni_registrar.h',
'android/chromecast_config_android.cc',
@@ -532,6 +534,7 @@
'type': 'none',
'sources': [
'browser/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java',
+ 'browser/android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroid.java',
'browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java',
'browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java',
],

Powered by Google App Engine
This is Rietveld 408576698