Chromecast: adds Android implementation of CastSysInfo.

chromecast/base/cast_sys_info_android.cc

Index: chromecast/base/cast_sys_info_android.cc
diff --git a/chromecast/base/cast_sys_info_android.cc b/chromecast/base/cast_sys_info_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..04524c0d7367c67e2d722e1cb4ffe3c659f1b218
--- /dev/null
+++ b/chromecast/base/cast_sys_info_android.cc
@@ -0,0 +1,124 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/base/cast_sys_info_android.h"
+
+#include "base/android/build_info.h"
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/sys_info.h"
+#include "chromecast/base/cast_sys_info_util.h"
+#include "chromecast/base/version.h"
+#include "jni/CastSysInfoAndroid_jni.h"
+
+namespace chromecast {
+
+namespace {
+const char kBuildTypeUser[] = "user";
+}  // namespace
+
+// static
+bool CastSysInfoAndroid::RegisterJni(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
+// static
+scoped_ptr<CastSysInfo> CreateSysInfo() {
+  return make_scoped_ptr(new CastSysInfoAndroid());
+}
+
+CastSysInfoAndroid::CastSysInfoAndroid()
+    : build_info_(base::android::BuildInfo::GetInstance()) {
+}
+
+CastSysInfoAndroid::~CastSysInfoAndroid() {
+}
+
+CastSysInfo::BuildType CastSysInfoAndroid::GetBuildType() {
+  if (CAST_IS_DEBUG_BUILD())
+    return BUILD_ENG;
+
+  int build_number;
+  if (!base::StringToInt(CAST_BUILD_INCREMENTAL, &build_number))
+    build_number = 0;
+
+  // Note: no way to determine which channel was used on play store.
+  if (strcmp(build_info_->build_type(), kBuildTypeUser) == 0 &&
+      build_number > 0) {
+    return BUILD_PRODUCTION;
+  }
+
+  // Dogfooders without a user system build should all still have non-Debug
+  // builds of the cast receiver APK, but with valid build numbers.
+  if (build_number > 0)
+    return BUILD_BETA;
+
+  // Default to ENG build.
+  return BUILD_ENG;
+}
+
+std::string CastSysInfoAndroid::GetSerialNumber() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  return base::android::ConvertJavaStringToUTF8(
+      Java_CastSysInfoAndroid_getSerialNumber(env));
+}
+
+std::string CastSysInfoAndroid::GetProductName() {
+  return build_info_->device();
+}
+
+std::string CastSysInfoAndroid::GetDeviceModel() {
+  return build_info_->model();
+}
+
+std::string CastSysInfoAndroid::GetManufacturer() {
+  return build_info_->manufacturer();
+}
+
+std::string CastSysInfoAndroid::GetSystemBuildNumber() {
+  return base::SysInfo::GetAndroidBuildID();
+}
+
+std::string CastSysInfoAndroid::GetSystemReleaseChannel() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetBoardName() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetBoardRevision() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetFactoryCountry() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetFactoryLocale(std::string* second_locale) {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetWifiInterface() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetApInterface() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetGlVendor() {
+  return "";

[halliwell, 2015/05/19 01:59:43]

Slightly separate issue (and I can submit a separate CL for this if you prefer)
... but looking at this reminded me that we actually don't want to call this
code on Android.  We could even ifdef these 3 GetGl* functions from the base API
on Android to make that totally clear ... ?

[gunsch, 2015/05/19 02:51:47]

How about I add a NOTREACHED in each of these instead?

I just noticed that these methods are called unconditionally in
CastBrowserMainParts though... should that call site actually be guarded?
(added).

[halliwell, 2015/05/19 03:36:18]

Yes, guarding the callsite is correct.  Not sure how I missed that ... but I
guess inheriting from the dummy implementation didn't help :)

+}
+
+std::string CastSysInfoAndroid::GetGlRenderer() {
+  return "";
+}
+
+std::string CastSysInfoAndroid::GetGlVersion() {
+  return "";
+}
+
+}  // namespace chromecast