Chromecast: adds Android implementation of CastSysInfo.

Chromecast: adds Android implementation of CastSysInfo.

R=lcwu@chromium.org,halliwell@chromium.org

Committed: https://crrev.com/e860606d53ad107ee875b55d07ef7624c84fc60c
Cr-Commit-Position: refs/heads/master@{#330595}

[gunsch, 2015-05-19 01:18:06]

This is a fairly straightforward port of CastSysInfoAndroid from internal repo,
with a couple changes:

* Moved version.h from chromecast/common to chromecast/base (ought to have been
there the whole time)
* Implemented CastSysInfo directly instead of CastSysInfoDummy (for some
"simple" implementations)
* Implemented GetSystemBuildNumber---I know it's not used right now in
cast_shell, but in case we add to metrics/etc. later.

[halliwell, 2015-05-19 01:59:43]

lgtm

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_android.cc (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_android.cc:113: return "";
Slightly separate issue (and I can submit a separate CL for this if you prefer)
... but looking at this reminded me that we actually don't want to call this
code on Android.  We could even ifdef these 3 GetGl* functions from the base API
on Android to make that totally clear ... ?

[lcwu1, 2015-05-19 02:01:44]

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_android.h (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_android.h:11: #include
"chromecast/base/cast_sys_info_dummy.h"
This header is no longer needed.

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/version.h.in
File chromecast/base/version.h.in (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/version.h.i...
chromecast/base/version.h.in:7: #ifndef CHROMECAST_COMMON_VERSION_INFO_H_
s/COMMON/BASE (and two more instances below)

[gunsch, 2015-05-19 02:51:47]

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_android.cc (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_android.cc:113: return "";
On 2015/05/19 01:59:43, halliwell wrote:
> Slightly separate issue (and I can submit a separate CL for this if you
prefer)
> ... but looking at this reminded me that we actually don't want to call this
> code on Android.  We could even ifdef these 3 GetGl* functions from the base
API
> on Android to make that totally clear ... ?

How about I add a NOTREACHED in each of these instead?

I just noticed that these methods are called unconditionally in
CastBrowserMainParts though... should that call site actually be guarded?
(added).

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_android.h (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_android.h:11: #include
"chromecast/base/cast_sys_info_dummy.h"
On 2015/05/19 02:01:44, lcwu1 wrote:
> This header is no longer needed.

Done.

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/version.h.in
File chromecast/base/version.h.in (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/version.h.i...
chromecast/base/version.h.in:7: #ifndef CHROMECAST_COMMON_VERSION_INFO_H_
On 2015/05/19 02:01:44, lcwu1 wrote:
> s/COMMON/BASE (and two more instances below)

Done.

[halliwell, 2015-05-19 03:36:18]

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_android.cc (right):

https://codereview.chromium.org/1132663004/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_android.cc:113: return "";
On 2015/05/19 02:51:47, gunsch wrote:
> On 2015/05/19 01:59:43, halliwell wrote:
> > Slightly separate issue (and I can submit a separate CL for this if you
> prefer)
> > ... but looking at this reminded me that we actually don't want to call this
> > code on Android.  We could even ifdef these 3 GetGl* functions from the base
> API
> > on Android to make that totally clear ... ?
> 
> How about I add a NOTREACHED in each of these instead?
> 
> I just noticed that these methods are called unconditionally in
> CastBrowserMainParts though... should that call site actually be guarded?
> (added).

Yes, guarding the callsite is correct.  Not sure how I missed that ... but I
guess inheriting from the dummy implementation didn't help :)

[lcwu1, 2015-05-19 16:11:35]

lgtm

[gunsch, 2015-05-19 16:45:32]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-19 16:45:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1132663004/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2015-05-19 16:47:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132663004/20001

[commit-bot: I haz the power, 2015-05-19 16:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 16:59:58]

Dry run: This issue passed the CQ dry run.

[byungchul, 2015-05-19 17:25:46]

byungchul@chromium.org changed reviewers:
+ byungchul@chromium.org

[byungchul, 2015-05-19 17:25:47]

lgtm

https://codereview.chromium.org/1132663004/diff/20001/chromecast/base/cast_sy...
File chromecast/base/cast_sys_info_android.cc (right):

https://codereview.chromium.org/1132663004/diff/20001/chromecast/base/cast_sy...
chromecast/base/cast_sys_info_android.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
2015

[gunsch, 2015-05-19 18:41:42]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-19 18:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org,
byungchul@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1132663004/#ps40001
(title: "copyright for new files")

[commit-bot: I haz the power, 2015-05-19 18:42:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132663004/40001

[commit-bot: I haz the power, 2015-05-19 18:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 18:47:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[gunsch, 2015-05-19 20:22:42]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-05-19 20:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org,
byungchul@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1132663004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-19 20:23:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132663004/60001

[commit-bot: I haz the power, 2015-05-19 20:29:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 20:30:26]

Patchset 4 (id:??) landed as
https://crrev.com/e860606d53ad107ee875b55d07ef7624c84fc60c
Cr-Commit-Position: refs/heads/master@{#330595}