Debugger: preserve stepping state after evaluating breakpoint condition.

src/debug.cc

Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 82fab36a2b83ea96c80042d232b06dda40db30c2..d477c865a3d42f4ea8b1a024ff77b8528364356f 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -897,6 +897,11 @@ Handle<Object> Debug::CheckBreakPoints(Handle<Object> break_point_objects) {
   Handle<FixedArray> break_points_hit;
   int break_points_hit_count = 0;
   DCHECK(!break_point_objects->IsUndefined());
+
+  // Break points are checked by calling into Javascript. This could change
+  // the stepping state we are currently in.
+  PreserveDebugState state(this);

[yurys, 2015/05/15 22:04:41]

I wonder how evaluating breakpoint condition can change the stepping state. The
conditional expression should be isolated from the debugger bindings and I
wouldn't expect it to affect the state. Could you educate me on this?

+
   if (break_point_objects->IsFixedArray()) {
     Handle<FixedArray> array(FixedArray::cast(*break_point_objects));
     break_points_hit = factory->NewFixedArray(array->length());