Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/debug.cc

Issue 1132643004: Debugger: preserve stepping state after evaluating breakpoint condition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | test/mjsunit/regress/regress-crbug-467180.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 82fab36a2b83ea96c80042d232b06dda40db30c2..d477c865a3d42f4ea8b1a024ff77b8528364356f 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -897,6 +897,11 @@ Handle<Object> Debug::CheckBreakPoints(Handle<Object> break_point_objects) {
Handle<FixedArray> break_points_hit;
int break_points_hit_count = 0;
DCHECK(!break_point_objects->IsUndefined());
+
+ // Break points are checked by calling into Javascript. This could change
+ // the stepping state we are currently in.
+ PreserveDebugState state(this);
yurys 2015/05/15 22:04:41 I wonder how evaluating breakpoint condition can c
+
if (break_point_objects->IsFixedArray()) {
Handle<FixedArray> array(FixedArray::cast(*break_point_objects));
break_points_hit = factory->NewFixedArray(array->length());
« no previous file with comments | « src/debug.h ('k') | test/mjsunit/regress/regress-crbug-467180.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698