Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_page_header.js

Issue 1132613003: Fixes for cr-settings-page-header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/settings_page_header.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_page_header.js b/chrome/browser/resources/settings/settings_page/settings_page_header.js
index fb02eba51c075332447b2e43fa260d114ae05f4f..7a151a8a980a67b5722127d70468f2c94d2ffa34 100644
--- a/chrome/browser/resources/settings/settings_page/settings_page_header.js
+++ b/chrome/browser/resources/settings/settings_page/settings_page_header.js
@@ -70,6 +70,8 @@ Polymer({
* @private
*/
getTopPageIcon_: function(pageStack) {
+ if (pageStack.length == 0)
+ return '';
return pageStack[0].icon;
},
@@ -88,17 +90,21 @@ Polymer({
* @private
*/
getCurrentPageTitle_: function(pageStack) {
+ if (pageStack.length == 0)
+ return '';
return pageStack[0].pageTitle;
},
/** @private */
selectedPageChanged_: function() {
- if (this.selectedPage.subpage) {
+ if (this.selectedPage && this.selectedPage.subpage) {
// NOTE: Must reassign pageStack rather than doing push() so that the
// computed property (parentPages) will be notified of the update.
this.pageStack = this.pageStack.concat(this.selectedPage);
- } else {
+ } else if (this.selectedPage) {
this.pageStack = [this.selectedPage];
+ } else {
+ this.pageStack = [];
}
},
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698