Issue 1132613003: Fixes for cr-settings-page-header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132613003: Fixes for cr-settings-page-header (Closed)

Created:
5 years, 7 months ago by michaelpg

Modified:
5 years, 7 months ago

Reviewers:
Jeremy Klein

CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixes for cr-settings-page-header BUG=485381 Committed: https://crrev.com/109bc3f60a83188de1f2d65dd132ca1d637cff9b Cr-Commit-Position: refs/heads/master@{#329762}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/resources/settings/settings_main/settings_main.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/settings/settings_page/settings_page_header.js	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132613003/1

5 years, 7 months ago (2015-05-13 23:28:13 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 00:28:44 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/109bc3f60a83188de1f2d65dd132ca1d637cff9b
Cr-Commit-Position: refs/heads/master@{#329762}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages