CRWSessionEntry: Replaced hardcoded strings with constants.

ios/web/navigation/crw_session_entry_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #import "ios/testing/ocmock_complex_type_helper.h"
 #import "ios/web/navigation/crw_session_entry.h"
@@ skipping 105 matching lines @@
       *length = 0;
       return NULL;
   };
 
   [[[decoder stub] andReturnValue:[NSNumber numberWithBool:NO]]
       containsValueForKey:[OCMArg any]];
 
   [decoder onSelector:@selector(decodeBytesForKey:returnedLength:)
       callBlockExpectation:block];
   [[[decoder expect] andReturn:virtualUrl]
-      decodeObjectForKey:@"virtualUrl"];
+      decodeObjectForKey:web::kSessionEntryURLDeperecatedKey];
   [[[decoder expect] andReturn:referrer]
-      decodeObjectForKey:@"referrer"];
+      decodeObjectForKey:web::kSessionEntryReferrerURLDeprecatedKey];
   [[[decoder expect] andReturn:title]
-      decodeObjectForKey:@"title"];
+      decodeObjectForKey:web::kSessionEntryTitleKey];
   const web::PageScrollState& scrollState =
       [sessionEntry_ navigationItem]->GetPageScrollState();
   NSDictionary* serializedScrollState =
       [CRWSessionEntry dictionaryFromScrollState:scrollState];
   [[[decoder expect] andReturn:serializedScrollState]
-      decodeObjectForKey:@"state"];
+      decodeObjectForKey:web::kSessionEntryPageScrollStateKey];
   BOOL useDesktopUserAgent =
       [sessionEntry_ navigationItem]->IsOverridingUserAgent();
   [[[decoder expect] andReturnValue:OCMOCK_VALUE(useDesktopUserAgent)]
-      decodeBoolForKey:@"useDesktopUserAgent"];
+      decodeBoolForKey:web::kSessionEntryUseDesktopUserAgentKey];
   NSDictionary* requestHeaders =
       [sessionEntry_ navigationItem]->GetHttpRequestHeaders();
   [[[decoder expect] andReturn:requestHeaders]
-      decodeObjectForKey:@"httpHeaders"];
+      decodeObjectForKey:web::kSessionEntryHTTPRequestHeadersKey];
   [[[decoder expect]
       andReturn:[sessionEntry_ navigationItemImpl]->GetPostData()]
-      decodeObjectForKey:@"POSTData"];
+      decodeObjectForKey:web::kSessionEntryPOSTDataKey];
   BOOL skipResubmitDataConfirmation =
       [sessionEntry_ navigationItemImpl]->ShouldSkipResubmitDataConfirmation();
   [[[decoder expect] andReturnValue:OCMOCK_VALUE(skipResubmitDataConfirmation)]
-      decodeBoolForKey:@"skipResubmitDataConfirmation"];
+      decodeBoolForKey:web::kSessionEntrySkipResubmitConfirmationKey];
 
   base::scoped_nsobject<CRWSessionEntry> newSessionEntry(
       [[CRWSessionEntry alloc] initWithCoder:decoder]);
   web::NavigationItem* newItem = [newSessionEntry navigationItem];
 
   EXPECT_OCMOCK_VERIFY(decoder);
   expectEqualSessionEntries(sessionEntry_, newSessionEntry,
                             ui::PAGE_TRANSITION_RELOAD);
   EXPECT_NE(item->GetURL(), newItem->GetURL());
   EXPECT_EQ(item->GetVirtualURL(), newItem->GetURL());
 }
 
 TEST_F(CRWSessionEntryTest, InitWithCoderNewStyle) {
   web::NavigationItem* item = [sessionEntry_ navigationItem];
   item->SetVirtualURL(GURL("http://user.friendly"));
   item->SetTitle(base::SysNSStringToUTF16(@"Title"));
   int64 timestamp = item->GetTimestamp().ToInternalValue();
 
   std::string virtualUrl = item->GetVirtualURL().spec();
   std::string referrerUrl = item->GetReferrer().url.spec();
   NSString* title = base::SysUTF16ToNSString(item->GetTitle());
   base::scoped_nsobject<id> decoder([[OCMockComplexTypeHelper alloc]
       initWithRepresentedObject:[OCMockObject mockForClass:[NSCoder class]]]);
 
   const std::string emptyString;
   decodeBytesForKeyBlock block =  ^ const uint8_t* (NSString* key,
                                                     NSUInteger* length) {
       const std::string *value = &emptyString;
-      if ([key isEqualToString:@"virtualUrlString"])
+      if ([key isEqualToString:web::kSessionEntryURLKey])
         value = &virtualUrl;
-      else if ([key isEqualToString:@"referrerUrlString"])
+      else if ([key isEqualToString:web::kSessionEntryReferrerURLKey])
         value = &referrerUrl;
       else
         EXPECT_TRUE(false);
 
       *length = value->size();
       return reinterpret_cast<const uint8_t*>(value->data());
   };
 
   [decoder onSelector:@selector(decodeBytesForKey:returnedLength:)
       callBlockExpectation:block];
   [[[decoder stub] andReturnValue:[NSNumber numberWithBool:YES]]
       containsValueForKey:[OCMArg any]];
   web::ReferrerPolicy expectedPolicy = item->GetReferrer().policy;
-  [[[decoder expect]
-      andReturnValue:OCMOCK_VALUE(expectedPolicy)]
-      decodeIntForKey:@"referrerPolicy"];
+  [[[decoder expect] andReturnValue:OCMOCK_VALUE(expectedPolicy)]
+      decodeIntForKey:web::kSessionEntryReferrerPolicyKey];
   [[[decoder expect] andReturnValue:OCMOCK_VALUE(timestamp)]
-      decodeInt64ForKey:@"timestamp"];
+      decodeInt64ForKey:web::kSessionEntryTimestampKey];
   [[[decoder expect] andReturn:title]
-      decodeObjectForKey:@"title"];
+      decodeObjectForKey:web::kSessionEntryTitleKey];
   const web::PageScrollState& scrollState =
       [sessionEntry_ navigationItem]->GetPageScrollState();
   NSDictionary* serializedScrollState =
       [CRWSessionEntry dictionaryFromScrollState:scrollState];
   [[[decoder expect] andReturn:serializedScrollState]
-      decodeObjectForKey:@"state"];
+      decodeObjectForKey:web::kSessionEntryPageScrollStateKey];
   BOOL useDesktopUserAgent =
       [sessionEntry_ navigationItem]->IsOverridingUserAgent();
   [[[decoder expect] andReturnValue:OCMOCK_VALUE(useDesktopUserAgent)]
-      decodeBoolForKey:@"useDesktopUserAgent"];
+      decodeBoolForKey:web::kSessionEntryUseDesktopUserAgentKey];
   NSDictionary* requestHeaders =
       [sessionEntry_ navigationItem]->GetHttpRequestHeaders();
   [[[decoder expect] andReturn:requestHeaders]
-      decodeObjectForKey:@"httpHeaders"];
+      decodeObjectForKey:web::kSessionEntryHTTPRequestHeadersKey];
   NSData* POSTData = [sessionEntry_ navigationItemImpl]->GetPostData();
-  [[[decoder expect] andReturn:POSTData] decodeObjectForKey:@"POSTData"];
+  [[[decoder expect] andReturn:POSTData]
+      decodeObjectForKey:web::kSessionEntryPOSTDataKey];
   BOOL skipResubmitDataConfirmation =
       [sessionEntry_ navigationItemImpl]->ShouldSkipResubmitDataConfirmation();
   [[[decoder expect] andReturnValue:OCMOCK_VALUE(skipResubmitDataConfirmation)]
-      decodeBoolForKey:@"skipResubmitDataConfirmation"];
+      decodeBoolForKey:web::kSessionEntrySkipResubmitConfirmationKey];
 
   base::scoped_nsobject<CRWSessionEntry> newSessionEntry(
       [[CRWSessionEntry alloc] initWithCoder:decoder]);
   web::NavigationItem* newItem = [newSessionEntry navigationItem];
 
   EXPECT_OCMOCK_VERIFY(decoder);
   expectEqualSessionEntries(sessionEntry_, newSessionEntry,
                             ui::PAGE_TRANSITION_RELOAD);
   EXPECT_NE(item->GetURL(), newItem->GetURL());
   EXPECT_EQ(item->GetVirtualURL(), newItem->GetVirtualURL());
 }
 
 TEST_F(CRWSessionEntryTest, EncodeDecode) {
   NSData *data =
       [NSKeyedArchiver archivedDataWithRootObject:sessionEntry_];
   id decoded = [NSKeyedUnarchiver unarchiveObjectWithData:data];
 
   expectEqualSessionEntries(sessionEntry_, decoded,
                             ui::PAGE_TRANSITION_RELOAD);
 }
 
 TEST_F(CRWSessionEntryTest, EncodeWithCoder) {
   web::NavigationItem* item = [sessionEntry_ navigationItem];
   NSString* title = base::SysUTF16ToNSString(item->GetTitle());
 
   base::scoped_nsobject<id> coder([[OCMockComplexTypeHelper alloc]
       initWithRepresentedObject:[OCMockObject mockForClass:[NSCoder class]]]);
 
-  encodeBytes_length_forKey_block block = ^(const uint8_t* bytes,
-                                            NSUInteger length,
-                                            NSString* key) {
-      if ([key isEqualToString:@"virtualUrlString"]) {
-        ASSERT_EQ(item->GetVirtualURL().spec(),
-                  std::string(reinterpret_cast<const char*>(bytes), length));
-        return;
-      } else if ([key isEqualToString:@"referrerUrlString"]) {
-        ASSERT_EQ(item->GetReferrer().url.spec(),
-                  std::string(reinterpret_cast<const char*>(bytes), length));
-        return;
-      }
-      FAIL();
-  };
+  encodeBytes_length_forKey_block block =
+      ^(const uint8_t* bytes, NSUInteger length, NSString* key) {
+        if ([key isEqualToString:web::kSessionEntryURLKey]) {
+          ASSERT_EQ(item->GetVirtualURL().spec(),
+                    std::string(reinterpret_cast<const char*>(bytes), length));
+          return;
+        } else if ([key isEqualToString:web::kSessionEntryReferrerURLKey]) {
+          ASSERT_EQ(item->GetReferrer().url.spec(),
+                    std::string(reinterpret_cast<const char*>(bytes), length));
+          return;
+        }
+        FAIL();
+      };
   [coder onSelector:@selector(encodeBytes:length:forKey:)
       callBlockExpectation:block];
   [[coder expect] encodeInt:item->GetReferrer().policy
-                     forKey:@"referrerPolicy"];
+                     forKey:web::kSessionEntryReferrerPolicyKey];
   [[coder expect] encodeInt64:item->GetTimestamp().ToInternalValue()
-                       forKey:@"timestamp"];
-  [[coder expect] encodeObject:title forKey:@"title"];
+                       forKey:web::kSessionEntryTimestampKey];
+  [[coder expect] encodeObject:title forKey:web::kSessionEntryTitleKey];
   const web::PageScrollState& scrollState =
       [sessionEntry_ navigationItem]->GetPageScrollState();
   NSDictionary* serializedScrollState =
       [CRWSessionEntry dictionaryFromScrollState:scrollState];
-  [[coder expect] encodeObject:serializedScrollState forKey:@"state"];
+  [[coder expect] encodeObject:serializedScrollState
+                        forKey:web::kSessionEntryPageScrollStateKey];
   BOOL useDesktopUserAgent =
       [sessionEntry_ navigationItem]->IsOverridingUserAgent();
-  [[coder expect] encodeBool:useDesktopUserAgent forKey:@"useDesktopUserAgent"];
+  [[coder expect] encodeBool:useDesktopUserAgent
+                      forKey:web::kSessionEntryUseDesktopUserAgentKey];
   NSDictionary* requestHeaders =
       [sessionEntry_ navigationItem]->GetHttpRequestHeaders();
   [[coder expect] encodeObject:requestHeaders
-                        forKey:@"httpHeaders"];
+                        forKey:web::kSessionEntryHTTPRequestHeadersKey];
   [[coder expect] encodeObject:[sessionEntry_ navigationItemImpl]->GetPostData()
-                        forKey:@"POSTData"];
+                        forKey:web::kSessionEntryPOSTDataKey];
   BOOL skipResubmitDataConfirmation =
       [sessionEntry_ navigationItemImpl]->ShouldSkipResubmitDataConfirmation();
   [[coder expect] encodeBool:skipResubmitDataConfirmation
-                      forKey:@"skipResubmitDataConfirmation"];
+                      forKey:web::kSessionEntrySkipResubmitConfirmationKey];
   [sessionEntry_ encodeWithCoder:coder];
   EXPECT_OCMOCK_VERIFY(coder);
 }
 
 TEST_F(CRWSessionEntryTest, CodingEncoding) {
   web::NavigationItem* item = [sessionEntry_ navigationItem];
   item->SetVirtualURL(GURL("http://user.friendly"));
   NSData* data = [NSKeyedArchiver archivedDataWithRootObject:sessionEntry_];
   EXPECT_TRUE(data != nil);
   CRWSessionEntry* unarchivedSessionEntry =
@@ skipping 22 matching lines @@
 TEST_F(CRWSessionEntryTest, NonEmptyVirtualUrl) {
   web::NavigationItem* item = [sessionEntry_ navigationItem];
   item->SetVirtualURL(GURL("http://user.friendly"));
   EXPECT_EQ(GURL("http://user.friendly/"), item->GetVirtualURL());
   EXPECT_EQ(GURL("http://init.test/"), item->GetURL());
 }
 
 TEST_F(CRWSessionEntryTest, EmptyDescription) {
   EXPECT_GT([[sessionEntry_ description] length], 0U);
 }