Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132523002: UMA to track the reason for re-auth (Closed)

Created:
5 years, 7 months ago by Nikita (slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UMA to track the reason for re-auth Landing https://codereview.chromium.org/1114543002/ BUG=469992 TBR=isherman@chromium.org Committed: https://crrev.com/eb9ce0de55f3746e59ea805ca954a1be849b3815 Cr-Commit-Position: refs/heads/master@{#328858}

Patch Set 1 #

Patch Set 2 : add new files #

Patch Set 3 : UserManagerBase: check for Local State instance while working with user prefs #

Patch Set 4 : initialize local state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -8 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 3 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/reauth_stats.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/reauth_stats.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc View 1 2 3 16 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_password_changed.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 5 chunks +25 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/user_manager/user_manager.h View 2 chunks +20 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.h View 2 chunks +9 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 7 chunks +64 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +42 lines, -0 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132523002/1
5 years, 7 months ago (2015-05-07 10:36:10 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/35062)
5 years, 7 months ago (2015-05-07 10:43:08 UTC) #4
Ivan Podogov
On 2015/05/07 10:43:08, I haz the power (commit-bot) wrote: > Dry run: Try jobs failed ...
5 years, 7 months ago (2015-05-07 11:23:44 UTC) #5
Nikita (slow)
On 2015/05/07 11:23:44, Ivan Podogov wrote: > On 2015/05/07 10:43:08, I haz the power (commit-bot) ...
5 years, 7 months ago (2015-05-07 12:11:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132523002/20001
5 years, 7 months ago (2015-05-07 12:12:59 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/15318)
5 years, 7 months ago (2015-05-07 13:03:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132523002/40001
5 years, 7 months ago (2015-05-07 13:52:38 UTC) #12
Nikita (slow)
Dmitry, please take a look. CL is identical to https://codereview.chromium.org/1114543002/ except patchset 3 which fixes ...
5 years, 7 months ago (2015-05-07 15:35:26 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132523002/60002
5 years, 7 months ago (2015-05-07 15:36:21 UTC) #17
Dmitry Polukhin
lgtm
5 years, 7 months ago (2015-05-07 15:48:57 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 18:22:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132523002/60002
5 years, 7 months ago (2015-05-07 22:17:27 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60002)
5 years, 7 months ago (2015-05-07 22:23:37 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 22:24:21 UTC) #24
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/eb9ce0de55f3746e59ea805ca954a1be849b3815
Cr-Commit-Position: refs/heads/master@{#328858}

Powered by Google App Engine
This is Rietveld 408576698