Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1132513005: Revert of PPC: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC: Resolve references to "this" the same way as normal variables (patchset #1 id:1 of https://codereview.chromium.org/1129803003/) Reason for revert: Original commit was reverted. Original issue's description: > PPC: Resolve references to "this" the same way as normal variables > > Port 18619d355192e2699203d12d9ebb9caea107b693 > > Original commit message: > Make the parser handle references to "this" as unresolved variables, so the > same logic as for the rest of function parameters is used for the receiver. > Minor additions to the code generation handle copying the receiver to the > context, along with the rest of the function parameters. > > Based on work by Adrian Perez de Castro <aperez@igalia.com>;. > > R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com > BUG= > > Committed: https://crrev.com/e0ec097b2f49c4c99a2e9490f4b1a09e02abfd4d > Cr-Commit-Position: refs/heads/master@{#28272} TBR=dstence@us.ibm.com,michael_dawson@ca.ibm.com,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/727e92eced9ef1eac618fec24787684f8bd577e4 Cr-Commit-Position: refs/heads/master@{#28305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
MTBrandyberry
Created Revert of PPC: Resolve references to "this" the same way as normal variables
5 years, 7 months ago (2015-05-07 22:15:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132513005/1
5 years, 7 months ago (2015-05-07 22:15:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 22:15:46 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 22:16:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/727e92eced9ef1eac618fec24787684f8bd577e4
Cr-Commit-Position: refs/heads/master@{#28305}

Powered by Google App Engine
This is Rietveld 408576698