Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1132513003: Call builtin code wrapped in functions from the bootstrapper. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call builtin code wrapped in functions from the bootstrapper. For the moment, we only pass the global object (the one we are setting up). A few smaller changes were necessary to avoid failures in test-object-observe/DontLeakContextOnObserve. Otherwise the global object would be retained by being context allocated, leading to test failure. R=jkummerow@chromium.org Committed: https://crrev.com/7f4fa3b8f17d53fde929f64fa314462df923e8e8 Cr-Commit-Position: refs/heads/master@{#28331}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Patch Set 3 : fix extra natives #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -100 lines) Patch
M src/array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/array-iterator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +17 lines, -10 lines 0 comments Download
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/collection-iterator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/generator.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-array-includes.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-object.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-reflect.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-spread.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-tostring.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-typedarray.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/i18n.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/json.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 1 4 chunks +10 lines, -10 lines 0 comments Download
M src/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/string.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/string-iterator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/symbol.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/templates.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/typedarray.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/uri.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/v8natives.js View 8 chunks +8 lines, -8 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-extra.js View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Yang
5 years, 7 months ago (2015-05-07 11:04:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132513003/1
5 years, 7 months ago (2015-05-07 11:20:13 UTC) #3
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/1132513003/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1132513003/diff/1/src/bootstrapper.cc#newcode1873 src/bootstrapper.cc:1873: // Set up the 'global' ...
5 years, 7 months ago (2015-05-07 13:49:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132513003/20001
5 years, 7 months ago (2015-05-07 14:01:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/190)
5 years, 7 months ago (2015-05-07 14:09:28 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132513003/20001
5 years, 7 months ago (2015-05-11 07:36:50 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/259)
5 years, 7 months ago (2015-05-11 07:46:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132513003/40001
5 years, 7 months ago (2015-05-11 07:51:32 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-11 08:15:01 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 08:15:09 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7f4fa3b8f17d53fde929f64fa314462df923e8e8
Cr-Commit-Position: refs/heads/master@{#28331}

Powered by Google App Engine
This is Rietveld 408576698