Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4450)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.h

Issue 1132493004: Enable extensions error button test that was failing on stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
index 5a8052b90240ed77630b08e99d73d7bda27a2571..9730dff02a0497ebf70213986a267eb1ce4df9cf 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
@@ -6,9 +6,11 @@
#define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_BROWSERTEST_H_
#include "chrome/browser/extensions/extension_test_notification_observer.h"
+#include "chrome/common/extensions/features/feature_channel.h"
#include "chrome/test/base/web_ui_browser_test.h"
#include "extensions/browser/test_management_policy.h"
#include "extensions/common/extension.h"
+#include "extensions/common/feature_switch.h"
class Profile;
@@ -40,6 +42,9 @@ class ExtensionSettingsUIBrowserTest : public WebUIBrowserTest {
void SetAutoConfirmUninstall();
+ // Enables the error console so errors are displayed in the extensions page.
+ void EnableErrorConsole();
+
private:
bool WaitForExtensionViewsToLoad();
const extensions::Extension* InstallUnpackedExtension(
@@ -56,6 +61,9 @@ class ExtensionSettingsUIBrowserTest : public WebUIBrowserTest {
base::FilePath test_data_dir_;
+ // Used to enable the error console.
+ scoped_ptr<extensions::FeatureSwitch::ScopedOverride> error_console_override_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsUIBrowserTest);
};

Powered by Google App Engine
This is Rietveld 408576698