Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js |
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js |
index b12d501df3090b5962fbc05b72ba3633b2053d9d..e835910a9bffe8f3b0724a683bbbac070e388123 100644 |
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js |
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js |
@@ -271,22 +271,63 @@ TEST_F('BasicExtensionSettingsWebUITest', 'testNonEmptyExtensionList', |
this.nextStep(); |
}); |
-function AsyncExtensionSettingsWebUITest() {} |
+function DisableErrorButtonExtensionSettingsWebUITest() {} |
-AsyncExtensionSettingsWebUITest.prototype = { |
+DisableErrorButtonExtensionSettingsWebUITest.prototype = { |
__proto__: ExtensionSettingsWebUITest.prototype, |
/** @override */ |
testGenPreamble: function() { |
+ GEN(' DisableErrorConsole();'); |
+ |
GEN(' InstallGoodExtension();'); |
GEN(' InstallErrorsExtension();'); |
}, |
}; |
-// Still fails on CrWinClang tester. BUG=463245 |
-TEST_F('AsyncExtensionSettingsWebUITest', |
- 'DISABLED_testErrorListButtonVisibility', |
- function() { |
+TEST_F('DisableErrorButtonExtensionSettingsWebUITest', |
+ 'errorListButtonsHiddenIfNotDev', function() { |
+ var testButtonVisibility = function() { |
+ var extensionList = $('extension-list-wrapper'); |
+ |
+ // 2 extensions are loaded: |
+ // The 'good' extension will have 0 errors. |
+ // The 'bad' extension will have >3 manifest errors and <3 runtime errors. |
+ // Both buttons should be hidden. |
+ |
+ var visibleButtons = extensionList.querySelectorAll( |
+ '.errors-link:not([hidden])'); |
+ expectEquals(0, visibleButtons.length); |
+ |
+ var hiddenButtons = extensionList.querySelectorAll('.errors-link[hidden]'); |
+ expectEquals(2, hiddenButtons.length); |
+ |
+ this.nextStep(); |
+ }; |
+ |
+ this.steps = [this.waitForPageLoad, |
+ this.enableDeveloperMode, |
+ testButtonVisibility, |
+ testDone]; |
+ this.nextStep(); |
+}); |
+ |
+function EnableErrorButtonExtensionSettingsWebUITest() {} |
+ |
+EnableErrorButtonExtensionSettingsWebUITest.prototype = { |
+ __proto__: ExtensionSettingsWebUITest.prototype, |
+ |
+ /** @override */ |
+ testGenPreamble: function() { |
+ GEN(' EnableErrorConsole();'); |
+ |
+ GEN(' InstallGoodExtension();'); |
+ GEN(' InstallErrorsExtension();'); |
+ }, |
+}; |
+ |
+TEST_F('EnableErrorButtonExtensionSettingsWebUITest', |
+ 'testErrorListButtonVisibility', function() { |
var testButtonVisibility = function() { |
var extensionList = $('extension-list-wrapper'); |