Enable extensions error button test that was failing on stable.

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
-// chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
-// ExtensionSettingsUIBrowserTest::InstallGoodExtension() in some of the tests.
-var GOOD_CRX_ID = 'ldnnhddmnhbkjipkidpdiheffobcpfmf';
+// The id of the extension from |InstallGoodExtension|.
+var GOOD_EXTENSION_ID = 'ldnnhddmnhbkjipkidpdiheffobcpfmf';

[Dan Beam, 2015/05/12 01:34:13]

\n

[hcarmona, 2015/05/12 17:20:13]

Done.

+// The id of the extension from |InstallErrorsExtension|.
+var ERROR_EXTENSION_ID = 'pdlpifnclfacjobnmbpngemkalkjamnf';
 
 /**
  * Test C++ fixture for settings WebUI testing.
  * @constructor
  * @extends {testing.Test}
  */
 function ExtensionSettingsUIBrowserTest() {}
 
 /**
  * TestFixture for extension settings WebUI testing.
@@ skipping 169 matching lines @@
     GEN('  InstallPackagedApp();');
 
     GEN('  SetAutoConfirmUninstall();');
   },
 
   /** @protected */
   verifyDisabledWorks: function() {
     var listener = new UpdateListener(
         chrome.developerPrivate.EventType.UNLOADED,
         function() {
-      var node = getRequiredElement(GOOD_CRX_ID);
+      var node = getRequiredElement(GOOD_EXTENSION_ID);
       assertTrue(node.classList.contains('inactive-extension'));
       this.nextStep();
     }.bind(this));
-    chrome.management.setEnabled(GOOD_CRX_ID, false);
+    chrome.management.setEnabled(GOOD_EXTENSION_ID, false);
   },
 
   /** @protected */
   verifyEnabledWorks: function() {
     var listener = new UpdateListener(
         chrome.developerPrivate.EventType.LOADED,
         function() {
-      var node = getRequiredElement(GOOD_CRX_ID);
+      var node = getRequiredElement(GOOD_EXTENSION_ID);
       assertFalse(node.classList.contains('inactive-extension'));
       this.nextStep();
     }.bind(this));
-    chrome.management.setEnabled(GOOD_CRX_ID, true);
+    chrome.management.setEnabled(GOOD_EXTENSION_ID, true);
   },
 
   /** @protected */
   verifyUninstallWorks: function() {
     var listener = new UpdateListener(
         chrome.developerPrivate.EventType.UNINSTALLED,
         function() {
-      assertEquals(null, $(GOOD_CRX_ID));
+      assertEquals(null, $(GOOD_EXTENSION_ID));
       this.nextStep();
     }.bind(this));
     chrome.test.runWithUserGesture(function() {
-      chrome.management.uninstall(GOOD_CRX_ID);
+      chrome.management.uninstall(GOOD_EXTENSION_ID);
     });
   },
 };
 
 // Verify that developer mode doesn't change behavior when the number of
 // extensions changes.
 TEST_F('BasicExtensionSettingsWebUITest', 'testDeveloperModeManyExtensions',
        function() {
   this.testDeveloperMode();
 });
@@ skipping 23 matching lines @@
     assertFalse($('extension-list-wrapper').hidden);
     assertTrue($('no-extensions').hidden);
     assertGT($('extension-settings-list').childNodes.length, 0);
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad, verifyListIsNotHiddenAndEmpty, testDone];
   this.nextStep();
 });
 
-function AsyncExtensionSettingsWebUITest() {}
+function ErrorConsoleExtensionSettingsWebUITest() {}
 
-AsyncExtensionSettingsWebUITest.prototype = {
+ErrorConsoleExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   testGenPreamble: function() {
+    GEN('  EnableErrorConsole();');
+

[Dan Beam, 2015/05/12 01:34:13]

why the \n?

[hcarmona, 2015/05/12 17:20:13]

It was to separate enabling the error console and installing the
extensions. Not really necessary. Removed.

     GEN('  InstallGoodExtension();');
     GEN('  InstallErrorsExtension();');
   },
 };
 
-// Still fails on CrWinClang tester. BUG=463245
-TEST_F('AsyncExtensionSettingsWebUITest',
-       'DISABLED_testErrorListButtonVisibility',
-    function() {
+TEST_F('ErrorConsoleExtensionSettingsWebUITest',
+       'testErrorListButtonVisibility', function() {
   var testButtonVisibility = function() {
     var extensionList = $('extension-list-wrapper');
 
-    // 2 extensions are loaded:
-    //   The 'good' extension will have 0 errors wich means no error button.
-    //   The 'bad' extension will have >3 manifest errors and <3 runtime errors.
-    //     This means there will be a single error button.
     var visibleButtons = extensionList.querySelectorAll(
         '.errors-link:not([hidden])');
     expectEquals(1, visibleButtons.length);
 
+    if (visibleButtons.length > 0) {
+      var errorLink = $(ERROR_EXTENSION_ID).querySelector('.errors-link');
+      expectEquals(visibleButtons[0], errorLink);
+
+      var errorIcon = errorLink.querySelector('img');
+      expectTrue(errorIcon.classList.contains('extension-error-warning-icon'));
+    }
+
     var hiddenButtons = extensionList.querySelectorAll('.errors-link[hidden]');
     expectEquals(1, hiddenButtons.length);
 
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad,
                 this.enableDeveloperMode,
                 testButtonVisibility,
                 testDone];
@@ skipping 51 matching lines @@
 };
 
 TEST_F('InstallGoodExtensionSettingsWebUITest', 'testAccessibility',
        function() {
   this.emptyTestForAccessibility();
 });
 
 TEST_F('InstallGoodExtensionSettingsWebUITest', 'showOptions', function() {
   var showExtensionOptions = function() {
     var optionsOverlay = extensions.ExtensionOptionsOverlay.getInstance();
-    optionsOverlay.setExtensionAndShow(GOOD_CRX_ID, 'GOOD!', '',
+    optionsOverlay.setExtensionAndShow(GOOD_EXTENSION_ID, 'GOOD!', '',
                                        this.nextStep.bind(this));
 
     // Preferred size changes don't happen in browser tests. Just fake it.
     document.querySelector('extensionoptions').onpreferredsizechanged(
         {width: 500, height: 500});
   };
 
   this.steps = [this.waitForPageLoad, showExtensionOptions, testDone];
   this.nextStep();
 });
@@ skipping 22 matching lines @@
  * @constructor
  * @extends {InstallGoodExtensionSettingsWebUITest}
  */
 function OptionsDialogExtensionSettingsWebUITest() {}
 
 OptionsDialogExtensionSettingsWebUITest.prototype = {
   __proto__: InstallGoodExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
-      '?options=' + GOOD_CRX_ID,
+      '?options=' + GOOD_EXTENSION_ID,
 };
 
 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility',
        function() {
   this.emptyTestForAccessibility();
 });