Enable extensions error button test that was failing on stable.

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 253 matching lines @@
     assertFalse($('extension-list-wrapper').hidden);
     assertTrue($('no-extensions').hidden);
     assertGT($('extension-settings-list').childNodes.length, 0);
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad, verifyListIsNotHiddenAndEmpty, testDone];
   this.nextStep();
 });
 
-function AsyncExtensionSettingsWebUITest() {}
+function DisableErrorButtonExtensionSettingsWebUITest() {}
 
-AsyncExtensionSettingsWebUITest.prototype = {
+DisableErrorButtonExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   testGenPreamble: function() {
+    GEN('  DisableErrorConsole();');
+
     GEN('  InstallGoodExtension();');
     GEN('  InstallErrorsExtension();');
   },
 };
 
-// Still fails on CrWinClang tester. BUG=463245
-TEST_F('AsyncExtensionSettingsWebUITest',
-       'DISABLED_testErrorListButtonVisibility',
-    function() {
+TEST_F('DisableErrorButtonExtensionSettingsWebUITest',
+       'errorListButtonsHiddenIfNotDev', function() {
   var testButtonVisibility = function() {
     var extensionList = $('extension-list-wrapper');
 
+    // 2 extensions are loaded:
+    //   The 'good' extension will have 0 errors.
+    //   The 'bad' extension will have >3 manifest errors and <3 runtime errors.
+    // Both buttons should be hidden.
+
+    var visibleButtons = extensionList.querySelectorAll(
+        '.errors-link:not([hidden])');
+    expectEquals(0, visibleButtons.length);
+
+    var hiddenButtons = extensionList.querySelectorAll('.errors-link[hidden]');
+    expectEquals(2, hiddenButtons.length);
+
+    this.nextStep();
+  };
+
+  this.steps = [this.waitForPageLoad,
+                this.enableDeveloperMode,
+                testButtonVisibility,
+                testDone];
+  this.nextStep();
+});
+
+function EnableErrorButtonExtensionSettingsWebUITest() {}
+
+EnableErrorButtonExtensionSettingsWebUITest.prototype = {
+  __proto__: ExtensionSettingsWebUITest.prototype,
+
+  /** @override */
+  testGenPreamble: function() {
+    GEN('  EnableErrorConsole();');
+
+    GEN('  InstallGoodExtension();');
+    GEN('  InstallErrorsExtension();');
+  },
+};
+
+TEST_F('EnableErrorButtonExtensionSettingsWebUITest',
+       'testErrorListButtonVisibility', function() {
+  var testButtonVisibility = function() {
+    var extensionList = $('extension-list-wrapper');
+
     // 2 extensions are loaded:
     //   The 'good' extension will have 0 errors wich means no error button.
     //   The 'bad' extension will have >3 manifest errors and <3 runtime errors.
     //     This means there will be a single error button.

[Devlin, 2015/05/07 21:33:56]

This seems weird to me.  The number and type of errors doesn't affect whether or
not the errors link shows (it shows with > 0 of either type).  So I think we can
remove this comment (and it's sibling above).  Also, it'd be good to double
check that the errors link shows up on the right extension (i.e., not the "good"
one).

For extra bonus points, we could check that the class on the icon is the "warn"
one, since we have log and warn level errors.  (You don't have to, but if it's
an easy fix - I think it should be - it could be nice.)

[hcarmona, 2015/05/07 22:49:53]

Comments were getting confusing: removed.
Updated test with additional checks for visible link.

     var visibleButtons = extensionList.querySelectorAll(
         '.errors-link:not([hidden])');
     expectEquals(1, visibleButtons.length);
 
     var hiddenButtons = extensionList.querySelectorAll('.errors-link[hidden]');
     expectEquals(1, hiddenButtons.length);
 
     this.nextStep();
   };
 
@@ skipping 105 matching lines @@
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility',
        function() {
   this.emptyTestForAccessibility();
 });