Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1132483003: Rewriting WebRTC output level tests to be more reliable under load. (Closed)

Created:
5 years, 7 months ago by phoglund_chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewriting WebRTC output level tests to be more reliable under load. This greatly reduces the variance in test execution time when running in parallel on a heavily loaded bot, in which setTimeout becomes increasingly unpredictable. These tests were quite sensitive to load - they run 200 consecutive setTimeout calls with short timeouts, but if the machine is under load it can take up to 1000 ms to call back to a 50 ms setTimeout. This means the test would take 200 * 1000 = 200 seconds to run, but it obviously times out long before then. Running with this patch, the tests reliably stay under 10 seconds of execution time even under the most heavy load, which is a massive improvement to reliability. The only risk I see with this patch is that the tests will become more resource-hungry when there are resources available, so maybe they will starve out other sensitive tests? BUG=472087 Committed: https://crrev.com/7fb54b10aeebc34263831fa55307cb333e67dba2 Cr-Commit-Position: refs/heads/master@{#329400}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Tweaking gather time #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M content/test/data/media/webrtc_test_audio.js View 1 2 3 4 chunks +31 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
phoglund_chromium
5 years, 7 months ago (2015-05-12 10:18:25 UTC) #2
kjellander_chromium
That's an elegant solution for this problem! lgtm but I suggest you move some of ...
5 years, 7 months ago (2015-05-12 12:38:47 UTC) #3
phoglund_chromium
Moving some of the patch's history here: "I first tried writing a smarter, compensating setInterval ...
5 years, 7 months ago (2015-05-12 12:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132483003/60001
5 years, 7 months ago (2015-05-12 12:47:02 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-12 13:52:38 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:53:28 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7fb54b10aeebc34263831fa55307cb333e67dba2
Cr-Commit-Position: refs/heads/master@{#329400}

Powered by Google App Engine
This is Rietveld 408576698