cc: Move raster_source from Tile to PrioritizedTile

cc: Move raster_source from Tile to PrioritizedTile

This moves more of the transitive state of the tile to PrioritizedTile
which has a shorter lifetime, avoiding us to update properties on the
tile.

BUG=

Committed: https://crrev.com/c5e91585651efbbaed34f4b90e4fcbfea75db7e1
Cr-Commit-Position: refs/heads/master@{#329556}

[hendrikw, 2015-05-12 17:48:16]

hendrikw@chromium.org changed reviewers:
+ vmpstr@chromium.org

[hendrikw, 2015-05-12 17:48:17]

Hi, PTAL, thanks!

[vmpstr, 2015-05-12 20:18:52]

Is there any perf impact from this patch?

https://codereview.chromium.org/1132443003/diff/1/cc/debug/rasterize_and_reco...
File cc/debug/rasterize_and_record_benchmark_impl.cc (right):

https://codereview.chromium.org/1132443003/diff/1/cc/debug/rasterize_and_reco...
cc/debug/rasterize_and_record_benchmark_impl.cc:186: RasterSource* raster_source
= tiling->raster_source();
This can move outside of the loop?

https://codereview.chromium.org/1132443003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1132443003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:3188:
prioritized_tile.tile()->AsValueWithPriorityInto(prioritized_tile, state);
Can you leave a TODO here to clean this up? I think it should be something like
prioritized_tile.AsValueInto(state); which would serialize a part of it and call
a similar function on the tile.

[hendrikw, 2015-05-12 21:40:18]

No change with performance.

https://codereview.chromium.org/1132443003/diff/1/cc/debug/rasterize_and_reco...
File cc/debug/rasterize_and_record_benchmark_impl.cc (right):

https://codereview.chromium.org/1132443003/diff/1/cc/debug/rasterize_and_reco...
cc/debug/rasterize_and_record_benchmark_impl.cc:186: RasterSource* raster_source
= tiling->raster_source();
On 2015/05/12 20:18:52, vmpstr wrote:
> This can move outside of the loop?

Done.

https://codereview.chromium.org/1132443003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1132443003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:3188:
prioritized_tile.tile()->AsValueWithPriorityInto(prioritized_tile, state);
On 2015/05/12 20:18:52, vmpstr wrote:
> Can you leave a TODO here to clean this up? I think it should be something
like
> prioritized_tile.AsValueInto(state); which would serialize a part of it and
call
> a similar function on the tile.

Done.

[vmpstr, 2015-05-12 21:47:50]

https://codereview.chromium.org/1132443003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1132443003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:3188:
prioritized_tile.tile()->AsValueWithPriorityInto(prioritized_tile, state);
I know you added todo in tile, but I just don't like this line.

A.B->Foo(A); is weird... Maybe either pass prioritized_tile.priority() and
prioritized_tile.raster_source() or something?

[hendrikw, 2015-05-12 22:13:42]

Ok, I went ahead and split the priority and tile related AsValueInto functions.

[vmpstr, 2015-05-12 23:52:11]

Can you make sure that traceviewer is happy with these changes (eg, you can
still display the using-gpu-memory heatmap). If it is, then lgtm.

https://codereview.chromium.org/1132443003/diff/60001/cc/resources/prioritize...
File cc/resources/prioritized_tile.cc (right):

https://codereview.chromium.org/1132443003/diff/60001/cc/resources/prioritize...
cc/resources/prioritized_tile.cc:28: void
PrioritizedTile::AsValueInto(base::trace_event::TracedValue* res) const {
nit: result or value instead of res

[hendrikw, 2015-05-13 00:22:30]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-05-13 00:22:31]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1132443003/#ps80001
(title: "rename var")

[commit-bot: I haz the power, 2015-05-13 00:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132443003/80001

[commit-bot: I haz the power, 2015-05-13 01:29:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-13 01:29:54]

Patchset 5 (id:??) landed as
https://crrev.com/c5e91585651efbbaed34f4b90e4fcbfea75db7e1
Cr-Commit-Position: refs/heads/master@{#329556}