Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1132423003: Fix redundant string conversions in SpdyFramerTests. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix redundant string conversions in SpdyFramerTests. This CL lands server change 93655511 by bnc. BUG=488484 Committed: https://crrev.com/00fd898b791854dfbdab137e915a75ad5d20d85a Cr-Commit-Position: refs/heads/master@{#330368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M net/spdy/spdy_framer_test.cc View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 7 months ago (2015-05-18 15:33:14 UTC) #2
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-18 15:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132423003/1
5 years, 7 months ago (2015-05-18 15:50:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 15:55:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:55:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00fd898b791854dfbdab137e915a75ad5d20d85a
Cr-Commit-Position: refs/heads/master@{#330368}

Powered by Google App Engine
This is Rietveld 408576698