Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1132393002: Check if temp file was created before OnPageDone called (Closed)

Created:
5 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if temp file was created before OnPageDone called Broken utility process may send PageDone message before browser asked for the page. In this case emf is not allocated yet and browser will crash later on playback. Renamed emf() to TakeEmf() to highlight changed ownership. BUG=none Committed: https://crrev.com/5c796832c90f68b332b0586f9e21959d1a4915f1 Cr-Commit-Position: refs/heads/master@{#329207}

Patch Set 1 #

Patch Set 2 : Mon May 11 10:22:01 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vitaly Buka (NO REVIEWS)
5 years, 7 months ago (2015-05-11 17:41:03 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 7 months ago (2015-05-11 18:11:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132393002/20001
5 years, 7 months ago (2015-05-11 18:17:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 18:46:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:48:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c796832c90f68b332b0586f9e21959d1a4915f1
Cr-Commit-Position: refs/heads/master@{#329207}

Powered by Google App Engine
This is Rietveld 408576698