Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1132353004: [turbofan] Fix Node::TrimInputCount() followed by Node::AppendInput() bug. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix Node::TrimInputCount() followed by Node::AppendInput() bug. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/178c0f5f056cb550492d906a14175b9b0ceabb81 Cr-Commit-Position: refs/heads/master@{#28452}

Patch Set 1 #

Patch Set 2 : Update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M src/compiler/node.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/node.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/node-unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 7 months ago (2015-05-18 15:02:21 UTC) #1
Michael Starzinger
LGTM. A bug in Node, what year is this? :)
5 years, 7 months ago (2015-05-18 15:18:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353004/20001
5 years, 7 months ago (2015-05-18 15:20:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 15:49:26 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:49:40 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/178c0f5f056cb550492d906a14175b9b0ceabb81
Cr-Commit-Position: refs/heads/master@{#28452}

Powered by Google App Engine
This is Rietveld 408576698