|
|
Created:
5 years, 7 months ago by dshwang Modified:
5 years, 7 months ago CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake sure GpuMemoryBufferImpl is unmapped on destruction.
BUG=475633
Committed: https://crrev.com/87389cc050cc98397d0de838036307c078147d59
Cr-Commit-Position: refs/heads/master@{#330782}
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
dongseong.hwang@intel.com changed reviewers: + ccameron@chromium.org, reveman@chromium.org
ccameron, could you review? it's extracted from https://codereview.chromium.org/1134993003/ as reveman requested because of unrelated change.
What's the reason for why we need to prevent this?
On 2015/05/15 21:24:57, reveman wrote: > What's the reason for why we need to prevent this? There is not crucial reason but it looks make sense. 1. It means some clients didn't unmap while the GpuMemoryBuffer is deleted. We don't want to allow the client use mapped memory after destruction. 2. In Android, ANativeWindow_release and ANativeWindow_unlockAndPost rely on HAL. Some vendor might assume ANativeWindow_release must be called after ANativeWindow_unlockAndPost
lgtm
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
The CQ bit was unchecked by dongseong.hwang@intel.com
On 2015/05/18 16:43:24, reveman wrote: > lgtm thank you for reviewing. ccameron, could you review as content/ owner?
dongseong.hwang@intel.com changed reviewers: - ccameron@chromium.org
dongseong.hwang@intel.com changed reviewers: + ccameron@chromium.org, sievers@chromium.org
ccameron, sievers: could you review this simple CL as owner?
lgtm
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/87389cc050cc98397d0de838036307c078147d59 Cr-Commit-Position: refs/heads/master@{#330782} |