Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1132353003: Make sure GpuMemoryBufferImpl is unmapped on destruction. (Closed)

Created:
5 years, 7 months ago by dshwang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure GpuMemoryBufferImpl is unmapped on destruction. BUG=475633 Committed: https://crrev.com/87389cc050cc98397d0de838036307c078147d59 Cr-Commit-Position: refs/heads/master@{#330782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
dshwang
ccameron, could you review? it's extracted from https://codereview.chromium.org/1134993003/ as reveman requested because of unrelated change.
5 years, 7 months ago (2015-05-15 17:34:13 UTC) #2
reveman
What's the reason for why we need to prevent this?
5 years, 7 months ago (2015-05-15 21:24:57 UTC) #3
dshwang
On 2015/05/15 21:24:57, reveman wrote: > What's the reason for why we need to prevent ...
5 years, 7 months ago (2015-05-18 08:03:19 UTC) #4
reveman
lgtm
5 years, 7 months ago (2015-05-18 16:43:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
5 years, 7 months ago (2015-05-19 10:18:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64561)
5 years, 7 months ago (2015-05-19 10:24:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
5 years, 7 months ago (2015-05-19 12:54:09 UTC) #11
dshwang
On 2015/05/18 16:43:24, reveman wrote: > lgtm thank you for reviewing. ccameron, could you review ...
5 years, 7 months ago (2015-05-19 12:54:40 UTC) #13
dshwang
ccameron, sievers: could you review this simple CL as owner?
5 years, 7 months ago (2015-05-20 10:23:37 UTC) #16
no sievers
lgtm
5 years, 7 months ago (2015-05-20 17:51:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132353003/1
5 years, 7 months ago (2015-05-20 17:59:40 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 19:32:18 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 19:34:13 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87389cc050cc98397d0de838036307c078147d59
Cr-Commit-Position: refs/heads/master@{#330782}

Powered by Google App Engine
This is Rietveld 408576698