Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1132333004: [Omnibox] Remove unused histograms. (Closed)

Created:
5 years, 7 months ago by groby-ooo-7-16
Modified:
5 years, 7 months ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Omnibox] Remove unused histograms. The histograms removed in this CL are not declared in histograms.xml and so are not collected at all - removing what is essentially dead code. R=sky@chromium.org BUG=none Committed: https://crrev.com/15017a9a2aabe274f20c5a719d2763fa166084fc Cr-Commit-Position: refs/heads/master@{#330153}

Patch Set 1 #

Patch Set 2 : Add missing #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/browser/autocomplete/history_quick_provider.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
groby-ooo-7-16
Hey Sky, it looks like you added those in https://codereview.chromium.org/6679049 with a "histograms.xml will be ...
5 years, 7 months ago (2015-05-15 00:21:12 UTC) #1
sky
Peter or Mark should review this. I added both as I'm not sure if Peter ...
5 years, 7 months ago (2015-05-15 00:54:23 UTC) #3
Peter Kasting
Mark is the right reviewer here.
5 years, 7 months ago (2015-05-15 00:57:09 UTC) #4
Mark P
lgtm
5 years, 7 months ago (2015-05-15 18:04:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132333004/20001
5 years, 7 months ago (2015-05-15 18:11:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 18:59:12 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:01:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15017a9a2aabe274f20c5a719d2763fa166084fc
Cr-Commit-Position: refs/heads/master@{#330153}

Powered by Google App Engine
This is Rietveld 408576698