Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: net/dns/dns_config_service_win.cc

Issue 1132333003: Fix uninitialized reads in DnsConfigServiceWin tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set 'set' explicitly Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/dns/dns_config_service_win.h" 5 #include "net/dns/dns_config_service_win.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 DnsSystemSettings::DnsSystemSettings() 439 DnsSystemSettings::DnsSystemSettings()
440 : policy_search_list(), 440 : policy_search_list(),
441 tcpip_search_list(), 441 tcpip_search_list(),
442 tcpip_domain(), 442 tcpip_domain(),
443 primary_dns_suffix(), 443 primary_dns_suffix(),
444 policy_devolution(), 444 policy_devolution(),
445 dnscache_devolution(), 445 dnscache_devolution(),
446 tcpip_devolution(), 446 tcpip_devolution(),
447 append_to_multi_label_name(), 447 append_to_multi_label_name(),
448 have_name_resolution_policy(false) { 448 have_name_resolution_policy(false) {
449 policy_search_list.set = false;
450 tcpip_search_list.set = false;
451 tcpip_domain.set = false;
452 primary_dns_suffix.set = false;
453
454 policy_devolution.enabled.set = false;
455 policy_devolution.level.set = false;
456 dnscache_devolution.enabled.set = false;
457 dnscache_devolution.level.set = false;
458 tcpip_devolution.enabled.set = false;
459 tcpip_devolution.level.set = false;
460
461 append_to_multi_label_name.set = false;
449 } 462 }
450 463
451 DnsSystemSettings::~DnsSystemSettings() { 464 DnsSystemSettings::~DnsSystemSettings() {
452 } 465 }
453 466
454 bool ParseSearchList(const base::string16& value, 467 bool ParseSearchList(const base::string16& value,
455 std::vector<std::string>* output) { 468 std::vector<std::string>* output) {
456 DCHECK(output); 469 DCHECK(output);
457 if (value.empty()) 470 if (value.empty())
458 return false; 471 return false;
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 } 779 }
767 780
768 } // namespace internal 781 } // namespace internal
769 782
770 // static 783 // static
771 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() { 784 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() {
772 return scoped_ptr<DnsConfigService>(new internal::DnsConfigServiceWin()); 785 return scoped_ptr<DnsConfigService>(new internal::DnsConfigServiceWin());
773 } 786 }
774 787
775 } // namespace net 788 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698