Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: net/dns/dns_config_service_win.cc

Issue 1132333003: Fix uninitialized reads in DnsConfigServiceWin tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Neater Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/dns/dns_config_service_win.h" 5 #include "net/dns/dns_config_service_win.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 430
431 for (size_t offset = 0; num_dots >= devolution.level.value; --num_dots) { 431 for (size_t offset = 0; num_dots >= devolution.level.value; --num_dots) {
432 offset = primary_suffix.find('.', offset + 1); 432 offset = primary_suffix.find('.', offset + 1);
433 config->search.push_back(primary_suffix.substr(offset + 1)); 433 config->search.push_back(primary_suffix.substr(offset + 1));
434 } 434 }
435 } 435 }
436 436
437 } // namespace 437 } // namespace
438 438
439 DnsSystemSettings::DnsSystemSettings() 439 DnsSystemSettings::DnsSystemSettings()
440 : policy_search_list(), 440 : policy_search_list({}),
441 tcpip_search_list(), 441 tcpip_search_list({}),
442 tcpip_domain(), 442 tcpip_domain({}),
443 primary_dns_suffix(), 443 primary_dns_suffix({}),
444 policy_devolution(), 444 policy_devolution({}),
445 dnscache_devolution(), 445 dnscache_devolution({}),
446 tcpip_devolution(), 446 tcpip_devolution({}),
447 append_to_multi_label_name(), 447 append_to_multi_label_name({}),
Nico 2015/05/12 00:32:16 Hm, isn't this uniform initialization too? Nicos-M
448 have_name_resolution_policy(false) { 448 have_name_resolution_policy(false) {
449 } 449 }
450 450
451 DnsSystemSettings::~DnsSystemSettings() { 451 DnsSystemSettings::~DnsSystemSettings() {
452 } 452 }
453 453
454 bool ParseSearchList(const base::string16& value, 454 bool ParseSearchList(const base::string16& value,
455 std::vector<std::string>* output) { 455 std::vector<std::string>* output) {
456 DCHECK(output); 456 DCHECK(output);
457 if (value.empty()) 457 if (value.empty())
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 } 766 }
767 767
768 } // namespace internal 768 } // namespace internal
769 769
770 // static 770 // static
771 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() { 771 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() {
772 return scoped_ptr<DnsConfigService>(new internal::DnsConfigServiceWin()); 772 return scoped_ptr<DnsConfigService>(new internal::DnsConfigServiceWin());
773 } 773 }
774 774
775 } // namespace net 775 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698