Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: net/dns/dns_config_service_win.h

Issue 1132333003: Fix uninitialized reads in DnsConfigServiceWin tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_DNS_DNS_CONFIG_SERVICE_WIN_H_ 5 #ifndef NET_DNS_DNS_CONFIG_SERVICE_WIN_H_
6 #define NET_DNS_DNS_CONFIG_SERVICE_WIN_H_ 6 #define NET_DNS_DNS_CONFIG_SERVICE_WIN_H_
7 7
8 // The sole purpose of dns_config_service_win.h is for unittests so we just 8 // The sole purpose of dns_config_service_win.h is for unittests so we just
9 // include these headers here. 9 // include these headers here.
10 #include <winsock2.h> 10 #include <winsock2.h>
(...skipping 29 matching lines...) Expand all
40 // are converted to punycode. 40 // are converted to punycode.
41 bool NET_EXPORT_PRIVATE ParseSearchList(const base::string16& value, 41 bool NET_EXPORT_PRIVATE ParseSearchList(const base::string16& value,
42 std::vector<std::string>* out); 42 std::vector<std::string>* out);
43 43
44 // All relevant settings read from registry and IP Helper. This isolates our 44 // All relevant settings read from registry and IP Helper. This isolates our
45 // logic from system calls and is exposed for unit tests. Keep it an aggregate 45 // logic from system calls and is exposed for unit tests. Keep it an aggregate
46 // struct for easy initialization. 46 // struct for easy initialization.
47 struct NET_EXPORT_PRIVATE DnsSystemSettings { 47 struct NET_EXPORT_PRIVATE DnsSystemSettings {
48 // The |set| flag distinguishes between empty and unset values. 48 // The |set| flag distinguishes between empty and unset values.
49 struct RegString { 49 struct RegString {
50 bool set; 50 bool set = false;
51 base::string16 value; 51 base::string16 value;
52 }; 52 };
53 53
54 struct RegDword { 54 struct RegDword {
55 bool set; 55 bool set = false;
56 DWORD value; 56 DWORD value;
57 }; 57 };
58 58
59 struct DevolutionSetting { 59 struct DevolutionSetting {
60 // UseDomainNameDevolution 60 // UseDomainNameDevolution
61 RegDword enabled; 61 RegDword enabled;
62 // DomainNameDevolutionLevel 62 // DomainNameDevolutionLevel
63 RegDword level; 63 RegDword level;
64 }; 64 };
65 65
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 DISALLOW_COPY_AND_ASSIGN(DnsConfigServiceWin); 141 DISALLOW_COPY_AND_ASSIGN(DnsConfigServiceWin);
142 }; 142 };
143 143
144 } // namespace internal 144 } // namespace internal
145 145
146 } // namespace net 146 } // namespace net
147 147
148 #endif // NET_DNS_DNS_CONFIG_SERVICE_WIN_H_ 148 #endif // NET_DNS_DNS_CONFIG_SERVICE_WIN_H_
149 149
OLDNEW
« no previous file with comments | « no previous file | net/dns/dns_config_service_win_unittest.cc » ('j') | net/dns/dns_config_service_win_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698