Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 113233002: Revert of Revert of remvoe duplicate impl for SkImageInfo flattening

Created:
7 years ago by rmistry
Modified:
7 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/113193003/ Reason for revert: The wrong CL was reverted accidently TBR=reed@google.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -315 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 1 chunk +35 lines, -16 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkPixelRef.h View 5 chunks +58 lines, -20 lines 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +4 lines, -6 lines 0 comments Download
M include/images/SkImageRef.h View 3 chunks +3 lines, -4 lines 0 comments Download
M include/images/SkImageRef_GlobalPool.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 2 chunks +22 lines, -10 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +18 lines, -19 lines 0 comments Download
M src/core/SkImageFilterUtils.cpp View 2 chunks +13 lines, -3 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 3 chunks +111 lines, -20 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M src/core/SkPixelRef.cpp View 6 chunks +56 lines, -32 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +20 lines, -8 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 3 chunks +25 lines, -26 lines 0 comments Download
M src/image/SkDataPixelRef.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/image/SkDataPixelRef.cpp View 2 chunks +18 lines, -7 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +3 lines, -13 lines 0 comments Download
M src/images/SkImageRef.cpp View 7 chunks +11 lines, -20 lines 0 comments Download
M src/images/SkImageRef_GlobalPool.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/images/SkImageRef_ashmem.h View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef_ashmem.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 5 chunks +19 lines, -15 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 3 chunks +23 lines, -15 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +4 lines, -33 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 chunk +13 lines, -11 lines 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/113233002/1
7 years ago (2013-12-11 21:07:25 UTC) #1
rmistry
Created Revert of Revert of remvoe duplicate impl for SkImageInfo flattening
7 years ago (2013-12-11 21:07:30 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-11 21:07:38 UTC) #3
Failed to apply patch for src/image/SkImage_Raster.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file src/image/SkImage_Raster.cpp
  Hunk #1 FAILED at 84.
  1 out of 1 hunk FAILED -- saving rejects to file
src/image/SkImage_Raster.cpp.rej

Patch:       src/image/SkImage_Raster.cpp
Index: src/image/SkImage_Raster.cpp
diff --git a/src/image/SkImage_Raster.cpp b/src/image/SkImage_Raster.cpp
index
a872ae36e52d3aad65b23fffa280544876b252d5..93de5ea3abb1765cd03d26a2855e93bac20e67dd
100644
--- a/src/image/SkImage_Raster.cpp
+++ b/src/image/SkImage_Raster.cpp
@@ -84,10 +84,8 @@
 
 SkImage_Raster::SkImage_Raster(const Info& info, SkData* data, size_t rowBytes)
         : INHERITED(info.fWidth, info.fHeight) {
-    SkBitmap::Config config = SkImageInfoToBitmapConfig(info);
-
-    fBitmap.setConfig(config, info.fWidth, info.fHeight, rowBytes,
info.fAlphaType);
-    fBitmap.setPixelRef(SkNEW_ARGS(SkDataPixelRef, (data)))->unref();
+    fBitmap.setConfig(info, rowBytes);
+    fBitmap.setPixelRef(SkNEW_ARGS(SkDataPixelRef, (info, data,
rowBytes)))->unref();
     fBitmap.setImmutable();
 }

Powered by Google App Engine
This is Rietveld 408576698