Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1132323004: Pass video overlay renderer preference to ProxyDecryptor. (Closed)

Created:
5 years, 7 months ago by sandersd (OOO until July 31)
Modified:
5 years, 7 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass video overlay renderer preference to ProxyDecryptor. This restores the ability for the prefixed EME API to use secure codecs when the renderer preference is set. BUG=489512 Committed: https://crrev.com/05df568260405ac2c13fbdaf6e8db4c3dd9999c4 Cr-Commit-Position: refs/heads/master@{#330642}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/encrypted_media_player_support.cc View 1 chunk +5 lines, -1 line 0 comments Download
M media/cdm/proxy_decryptor.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M media/cdm/proxy_decryptor.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sandersd (OOO until July 31)
5 years, 7 months ago (2015-05-19 20:33:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132323004/1
5 years, 7 months ago (2015-05-19 20:35:37 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/39203) linux_chromium_gn_rel on ...
5 years, 7 months ago (2015-05-19 20:47:26 UTC) #6
ddorwin
LGTM with build fix. I added "EME" to the commit message. https://codereview.chromium.org/1132323004/diff/1/media/cdm/proxy_decryptor.h File media/cdm/proxy_decryptor.h (right): ...
5 years, 7 months ago (2015-05-19 20:47:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132323004/20001
5 years, 7 months ago (2015-05-19 20:49:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 22:38:30 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:39:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05df568260405ac2c13fbdaf6e8db4c3dd9999c4
Cr-Commit-Position: refs/heads/master@{#330642}

Powered by Google App Engine
This is Rietveld 408576698