Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: runtime/vm/service_test.cc

Issue 1132323002: Add Service ID zones to service protocol (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
diff --git a/runtime/vm/service_test.cc b/runtime/vm/service_test.cc
index fd3ec237f7f9267dfd3572cbac09bf71349c67be..0e4d3613b0af62393859802a2312342ae62bcd2f 100644
--- a/runtime/vm/service_test.cc
+++ b/runtime/vm/service_test.cc
@@ -108,6 +108,38 @@ static RawClass* GetClass(const Library& lib, const char* name) {
}
+TEST_CASE(Service_IdZones) {
+ Isolate* isolate = Isolate::Current();
+ ObjectIdRing* ring = isolate->object_id_ring();
+
+ const String& test_a = String::Handle(isolate, String::New("a"));
+ const String& test_b = String::Handle(isolate, String::New("b"));
+ const String& test_c = String::Handle(isolate, String::New("c"));
+ const String& test_d = String::Handle(isolate, String::New("d"));
+
+ // Both RingServiceIdZones share the same backing store and id space.
+
+ // Always allocate a new id.
+ RingServiceIdZone always_new_zone(ring, ObjectIdRing::kAllocateId);
+ EXPECT_STREQ("objects/0", always_new_zone.GetServiceId(test_a));
+ EXPECT_STREQ("objects/1", always_new_zone.GetServiceId(test_a));
+ EXPECT_STREQ("objects/2", always_new_zone.GetServiceId(test_a));
+ EXPECT_STREQ("objects/3", always_new_zone.GetServiceId(test_b));
+ EXPECT_STREQ("objects/4", always_new_zone.GetServiceId(test_c));
+
+ // Reuse an existing id or allocate a new id.
+ RingServiceIdZone reuse_zone(ring, ObjectIdRing::kReuseId);
+ EXPECT_STREQ("objects/0", reuse_zone.GetServiceId(test_a));
+ EXPECT_STREQ("objects/0", reuse_zone.GetServiceId(test_a));
+ EXPECT_STREQ("objects/3", reuse_zone.GetServiceId(test_b));
+ EXPECT_STREQ("objects/3", reuse_zone.GetServiceId(test_b));
+ EXPECT_STREQ("objects/4", reuse_zone.GetServiceId(test_c));
+ EXPECT_STREQ("objects/4", reuse_zone.GetServiceId(test_c));
+ EXPECT_STREQ("objects/5", reuse_zone.GetServiceId(test_d));
+ EXPECT_STREQ("objects/5", reuse_zone.GetServiceId(test_d));
+}
+
+
TEST_CASE(Service_Code) {
const char* kScript =
"var port;\n" // Set to our mock port by C++.
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698