Add Service ID zones to service protocol

runtime/vm/service_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "include/dart_debugger_api.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
@@ skipping 90 matching lines @@
 
 
 static RawClass* GetClass(const Library& lib, const char* name) {
   const Class& cls = Class::Handle(
       lib.LookupClass(String::Handle(Symbols::New(name))));
   EXPECT(!cls.IsNull());  // No ambiguity error expected.
   return cls.raw();
 }
 
 
+TEST_CASE(Service_IdZones) {
+  Isolate* isolate = Isolate::Current();
+
+  const String& test_a = String::Handle(isolate, String::New("a"));
+  const String& test_b = String::Handle(isolate, String::New("b"));
+  const String& test_c = String::Handle(isolate, String::New("c"));
+  const String& test_d = String::Handle(isolate, String::New("d"));
+
+  // Both RingServiceIdZones share the same backing store and id space.
+
+  // Always allocate a new id.
+  RingServiceIdZone always_new_zone(ObjectIdRing::kNewId);
+  EXPECT_STREQ("objects/0", always_new_zone.GetServiceId(test_a));
+  EXPECT_STREQ("objects/1", always_new_zone.GetServiceId(test_a));
+  EXPECT_STREQ("objects/2", always_new_zone.GetServiceId(test_a));
+  EXPECT_STREQ("objects/3", always_new_zone.GetServiceId(test_b));
+  EXPECT_STREQ("objects/4", always_new_zone.GetServiceId(test_c));
+
+  // Reuse an existing id or allocate a new id.
+  RingServiceIdZone reuse_zone(ObjectIdRing::kExistingOrNewId);
+  EXPECT_STREQ("objects/0", reuse_zone.GetServiceId(test_a));
+  EXPECT_STREQ("objects/0", reuse_zone.GetServiceId(test_a));
+  EXPECT_STREQ("objects/3", reuse_zone.GetServiceId(test_b));
+  EXPECT_STREQ("objects/3", reuse_zone.GetServiceId(test_b));
+  EXPECT_STREQ("objects/4", reuse_zone.GetServiceId(test_c));
+  EXPECT_STREQ("objects/4", reuse_zone.GetServiceId(test_c));
+  EXPECT_STREQ("objects/5", reuse_zone.GetServiceId(test_d));
+  EXPECT_STREQ("objects/5", reuse_zone.GetServiceId(test_d));
+
+  // Growable object array as storage.
+  const GrowableObjectArray& storage =
+      GrowableObjectArray::Handle(isolate, GrowableObjectArray::New());
+  // Zone whose id's will be "growable/index".
+  GrowableServiceIdZone growable_zone("growable/%" Pd "", storage);
+
+  // Prime the table with test_c and test_d. This has the side effect of giving
+  // test_c and test_d indexes 0 and 1 respectively.
+  storage.Add(test_c);
+  storage.Add(test_d);
+
+  // Verify that we get expect ids back for primed objects.
+  EXPECT_STREQ("growable/0", growable_zone.GetServiceId(test_c));
+  EXPECT_STREQ("growable/0", growable_zone.GetServiceId(test_c));
+  EXPECT_STREQ("growable/1", growable_zone.GetServiceId(test_d));
+  EXPECT_STREQ("growable/1", growable_zone.GetServiceId(test_d));
+
+  // Add new object.
+  EXPECT_STREQ("growable/2", growable_zone.GetServiceId(test_a));
+  EXPECT_STREQ("growable/2", growable_zone.GetServiceId(test_a));
+
+  // Add new object.
+  EXPECT_STREQ("growable/3", growable_zone.GetServiceId(test_b));
+  EXPECT_STREQ("growable/3", growable_zone.GetServiceId(test_b));
+
+  // Verify contents of storage.
+  EXPECT_EQ(test_c.raw(), storage.At(0));
+  EXPECT_EQ(test_d.raw(), storage.At(1));
+  EXPECT_EQ(test_a.raw(), storage.At(2));
+  EXPECT_EQ(test_b.raw(), storage.At(3));
+}
+
+
 TEST_CASE(Service_Code) {
   const char* kScript =
       "var port;\n"  // Set to our mock port by C++.
       "\n"
       "class A {\n"
       "  var a;\n"
       "  dynamic b() {}\n"
       "  dynamic c() {\n"
       "    var d = () { b(); };\n"
       "    return d;\n"
@@ skipping 467 matching lines @@
       Eval(lib, "[0, port, '0', 'getCpuProfile', ['tags'], ['Bogus']]");
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   // Expect error.
   EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg());
 }
 
 #endif  // !defined(TARGET_ARCH_ARM64)
 
 }  // namespace dart