Add Service ID zones to service protocol

runtime/vm/service/vmservice.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library vmservice;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:isolate';
 import 'dart:typed_data';
@@ skipping 124 matching lines @@
     var members = [];
     var result = {};
     clients.forEach((client) {
       members.add(client.toJson());
     });
     result['type'] = 'ClientList';
     result['members'] = members;
     message.setResponse(JSON.encode(result));
   }
 
+  // TODO(johnmccutchan): Turn this into a command line tool that uses the
+  // service library.
   Future<String> _getCrashDump() async {
     final perIsolateRequests = [
         // ?isolateId=<isolate id> will be appended to each of these requests.
-        Uri.parse('getIsolate'),             // Isolate information.
-        Uri.parse('_getAllocationProfile'),  // State of heap.
-        Uri.parse('getStack?full=true'),     // Call stack + local variables.
+        // Isolate information.
+        Uri.parse('getIsolate?_serviceIdZone=Ring.ExistingId'),
+        // State of heap.
+        Uri.parse('_getAllocationProfile?_serviceIdZone=Ring.ExistingId'),
+        // Call stack + local variables.
+        Uri.parse('getStack?_serviceIdZone=Ring.ExistingId&_full=true'),
     ];
 
     // Snapshot of running isolates.
     var isolates = runningIsolates.isolates.values.toList();
 
     // Collect the mapping from request uris to responses.
     var responses = {
     };
 
     // Request VM.
@@ skipping 10 matching lines @@
 
     // Make requests to each isolate.
     for (var isolate in isolates) {
       for (var request in perIsolateRequests) {
         var message = new Message.forIsolate(request, isolate);
         // Decode the JSON and and insert it into the map. The map key
         // is the request Uri.
         var response = JSON.decode(await isolate.route(message));
         responses[message.toUri().toString()] = response['result'];
       }
+      // Dump the object id ring requests.
+      var message =
+          new Message.forIsolate(Uri.parse('_dumpRingRequests'), isolate);

[turnidge, 2015/05/11 19:48:45]

We shouldn't leak the word "Ring" here.

Maybe _dumpRingRequests -> _dumpZone?

+      var response = JSON.decode(await isolate.route(message));
+      // Insert object id requests into responses map.
+      response['result']['ringRequests'].forEach((k, v) {

[turnidge, 2015/05/11 19:48:45]

We shouldn't use the word "ring" here in "ringRequests".  It leaks
implementation details that aren't needed by the protocol user.

+        responses[k + '&isolateId=${isolate.serviceId}'] = v;
+      });
     }
 
     // Encode the entire crash dump.
     return JSON.encode({
       'id' : null,
       'result' : responses,
     });
   }
 
   Future<String> route(Message message) {
@@ skipping 21 matching lines @@
 }
 
 void _registerIsolate(int port_id, SendPort sp, String name) {
   var service = new VMService();
   service.runningIsolates.isolateStartup(port_id, sp, name);
 }
 
 void _onStart() native "VMService_OnStart";
 
 void _onExit() native "VMService_OnExit";