Clean up weird ClientSocketPoolBase and WebSocket unit tests.

Clean up weird ClientSocketPoolBase unit tests.

The tests were re-entrantly reusing a TestCompletionCallback subclass in
a weird manner, which has now been fixed.  Also fix a WebSocket test
modelled after them.

BUG=114130
Committed: https://crrev.com/33d24423df4b30680edc9a473b945a8ca7b50127
Cr-Commit-Position: refs/heads/master@{#330585}

[mmenke, 2015-05-18 21:03:34]

Patchset #3 (id:40001) has been deleted

[mmenke, 2015-05-18 21:07:55]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org, ricea@chromium.org

[mmenke, 2015-05-18 21:07:55]

eroman:  Please review net/socket/client_socket_pool_base_unittest.cc.
ricea:  Please review socket/websocket_transport_client_socket_pool_unittest.cc

Ran into these when I was trying to switch net::TestCompletionCallback over to
using RunLoop.  It broke these tests on iOS (Not elsewhere, curiously), and I
decided the tests were funky enough to be worth fixing.

https://codereview.chromium.org/1132313004/diff/60001/net/socket/websocket_tr...
File net/socket/websocket_transport_client_socket_pool_unittest.cc (right):

https://codereview.chromium.org/1132313004/diff/60001/net/socket/websocket_tr...
net/socket/websocket_transport_client_socket_pool_unittest.cc:399:
EXPECT_EQ(ERR_IO_PENDING, rv);
The old test was synchronous, but it was relying on spinning the message loop
re-entrantly, which was needed for the WebSocketEndpointLockManager to release
the the lock while spinning the message loop, something that normally can't
happen in the middle of this callback.

So I switched this test to be asynchronous.

[eroman, 2015-05-18 21:21:20]

lgtm

[Adam Rice, 2015-05-19 19:21:51]

lgtm. Thank you for the cleanup.

[mmenke, 2015-05-19 19:23:22]

On 2015/05/19 19:21:51, Adam Rice wrote:
> lgtm. Thank you for the cleanup.

Thank you both.

[mmenke, 2015-05-19 19:23:25]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-05-19 19:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132313004/80001

[commit-bot: I haz the power, 2015-05-19 19:41:19]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-05-19 19:42:03]

Patchset 4 (id:??) landed as
https://crrev.com/33d24423df4b30680edc9a473b945a8ca7b50127
Cr-Commit-Position: refs/heads/master@{#330585}