Don't destroy the window in PlatformWindow's destructor.

Don't destroy the window in PlatformWindow's destructor.

This should have already been closed before we get to the destructor. Otherwise we get double deletes since the Destroy() call can end up calling the delegate which will delete this object.

Also in the X11 implementation, don't call delegate's OnClosed() before null'ing xwindow_, otherwise Destroy() can be called multiple times.

This is split off https://codereview.chromium.org/1139673003

BUG=484234
Committed: https://crrev.com/133ead2f6c4ecf2efb8905fb4cbfaada614847fc
Cr-Commit-Position: refs/heads/master@{#330381}

[jam, 2015-05-18 16:08:57]

jam@chromium.org changed reviewers:
+ ben@chromium.org

[jam, 2015-05-18 16:15:36]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-18 16:16:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132313003/1

[commit-bot: I haz the power, 2015-05-18 17:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-18 17:13:46]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2015-05-18 18:20:41]

lgtm

[jam, 2015-05-18 18:21:42]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-05-18 18:24:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132313003/1

[commit-bot: I haz the power, 2015-05-18 20:00:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-18 22:40:51]

Patchset 1 (id:??) landed as
https://crrev.com/133ead2f6c4ecf2efb8905fb4cbfaada614847fc
Cr-Commit-Position: refs/heads/master@{#330381}

[eugenis, 2015-05-19 17:43:42]

This change is causing HANDLE LEAK reports on DrMemory/Windows.

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

HANDLE LEAK: USER handle 0x00040200 and 90 similar handle(s) were opened but not
closed:
# 0 system call NtUserCreateWindowEx
# 1 USER32.dll!UnregisterClassW                                           +0x963
   (0x7548a8e8 <USER32.dll+0x1a8e8>)
# 2 USER32.dll!UnregisterClassW                                           +0xab7
   (0x7548aa3c <USER32.dll+0x1aa3c>)
# 3 USER32.dll!CreateWindowExW                                            +0x32 
   (0x75488a5c <USER32.dll+0x18a5c>)
# 4 gfx.dll!gfx::WindowImpl::Init                                         
[ui\gfx\win\window_impl.cc:214]
# 5 win_window.dll!ui::WinWindow::WinWindow                               
[ui\platform_window\win\win_window.cc:47]
# 6 aura.dll!aura::WindowTreeHostWin::WindowTreeHostWin                   
[ui\aura\window_tree_host_win.cc:48]
# 7 aura.dll!aura::WindowTreeHost::Create                                 
[ui\aura\window_tree_host_win.cc:36]
# 8 aura::TestScreen::CreateHostForPrimaryDisplay                         
[ui\aura\test\test_screen.cc:46]
# 9 aura::test::AuraTestHelper::SetUp                                     
[ui\aura\test\aura_test_helper.cc:70]
#10 content::RenderViewHostTestHarness::SetUp                             
[content\public\test\test_renderer_host.cc:195]
#11 content::NavigationControllerTest::SetUp                              
[content\browser\frame_host\navigation_controller_impl_unittest.cc:194]
#12 testing::internal::HandleExceptionsInMethodIfSupported<>              
[testing\gtest\src\gtest.cc:2420]
Note: @0:11:26.806 in thread 1288