Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1132303005: Correctly convert warp bounds from screen to native. (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, sadrul, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly convert warp bounds from screen to native. This is a regression in https://codereview.chromium.org/1114633002c BUG=485832 TEST=covered by unittests Committed: https://crrev.com/48060cf46055a412e7ce74438062815ba9a6659a Cr-Commit-Position: refs/heads/master@{#329567}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : added SupportsMultipleDisplays check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -19 lines) Patch
M ash/ash.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_util.cc View 1 2 chunks +7 lines, -17 lines 0 comments Download
A ash/display/display_util_unittest.cc View 1 2 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
oshima
5 years, 7 months ago (2015-05-12 16:44:06 UTC) #4
Jun Mukai
lgtm with nits https://codereview.chromium.org/1132303005/diff/40001/ash/display/display_util.cc File ash/display/display_util.cc (right): https://codereview.chromium.org/1132303005/diff/40001/ash/display/display_util.cc#newcode13 ash/display/display_util.cc:13: #include "ash/wm/window_util.h" Is this necessary? https://codereview.chromium.org/1132303005/diff/40001/ash/display/display_util.cc#newcode169 ...
5 years, 7 months ago (2015-05-12 17:08:46 UTC) #5
oshima
https://codereview.chromium.org/1132303005/diff/40001/ash/display/display_util.cc File ash/display/display_util.cc (right): https://codereview.chromium.org/1132303005/diff/40001/ash/display/display_util.cc#newcode13 ash/display/display_util.cc:13: #include "ash/wm/window_util.h" On 2015/05/12 17:08:46, Jun Mukai wrote: > ...
5 years, 7 months ago (2015-05-12 18:24:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132303005/60001
5 years, 7 months ago (2015-05-12 18:25:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/82968)
5 years, 7 months ago (2015-05-12 19:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132303005/80001
5 years, 7 months ago (2015-05-13 00:50:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 7 months ago (2015-05-13 02:12:38 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 02:13:29 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/48060cf46055a412e7ce74438062815ba9a6659a
Cr-Commit-Position: refs/heads/master@{#329567}

Powered by Google App Engine
This is Rietveld 408576698