Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1132303003: Add %GetUndetectable() test intrinsic and add tests for undetectables. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add %GetUndetectable() test intrinsic and add tests for undetectables. R=verwaest@chromium.org BUG= Committed: https://crrev.com/f750cc09bee465eef72be9fb8d85b095dacea403 Cr-Commit-Position: refs/heads/master@{#28338}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -0 lines) Patch
M src/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/undetectable.js View 1 1 chunk +87 lines, -0 lines 0 comments Download
A test/mjsunit/undetectable-compare.js View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 7 months ago (2015-05-11 09:16:29 UTC) #1
Toon Verwaest
lgtm https://codereview.chromium.org/1132303003/diff/1/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/1132303003/diff/1/src/runtime/runtime-test.cc#newcode221 src/runtime/runtime-test.cc:221: desc->InstanceTemplate()->MarkAsUndetectable(); // undetectable Seems like you just want ...
5 years, 7 months ago (2015-05-11 09:46:34 UTC) #2
titzer
https://codereview.chromium.org/1132303003/diff/1/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/1132303003/diff/1/src/runtime/runtime-test.cc#newcode221 src/runtime/runtime-test.cc:221: desc->InstanceTemplate()->MarkAsUndetectable(); // undetectable On 2015/05/11 09:46:34, Toon Verwaest wrote: ...
5 years, 7 months ago (2015-05-11 10:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132303003/20001
5 years, 7 months ago (2015-05-11 11:05:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 11:28:57 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 11:29:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f750cc09bee465eef72be9fb8d85b095dacea403
Cr-Commit-Position: refs/heads/master@{#28338}

Powered by Google App Engine
This is Rietveld 408576698