Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1132293005: Roll PDFium to f33cdd5 (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
CC:
jochen (gone - plz use gerrit), chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to f33cdd5 f33cdd5 Make CFX_StringData be scoped 8b2d91c Fix integer overflow in conversion from float to integer. 1b8a296 Use phantom handles instead of weak handles 8aa1eac Tidy public/ directory. fdc5e69 Fix comparison of CFX_ByteString and CFX_WideString against empty literals. 2a47d8d Set pointers in internal fields directly instead of wrapping them b2aa543 Make (and verify) public/ files compile under C. e6bd866 Describe required properties of public/ files with a README. feb10c5 Restore checked strlen conversions. Also makes a corresponding change to pdfium_engine.cc to match a changed pdfium API. Committed: https://crrev.com/62995cf3e960ca14e7a68ce9c4ccdf4d87a697b7 Cr-Commit-Position: refs/heads/master@{#330044}

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tom Sepez
Taking over from https://codereview.chromium.org/1141143002/
5 years, 7 months ago (2015-05-15 00:55:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-15 00:55:55 UTC) #4
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-15 04:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132293005/20001
5 years, 7 months ago (2015-05-15 04:53:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 04:57:45 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 05:00:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62995cf3e960ca14e7a68ce9c4ccdf4d87a697b7
Cr-Commit-Position: refs/heads/master@{#330044}

Powered by Google App Engine
This is Rietveld 408576698