content/browser/android/in_process/context_provider_in_process.cc - Issue 1132283003: Merge Group Markers into Chromium Traces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/context_provider_in_process.cc

Issue 1132283003: Merge Group Markers into Chromium Traces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed extra c_str() call Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/in_process/context_provider_in_process.cc

diff --git a/content/browser/android/in_process/context_provider_in_process.cc b/content/browser/android/in_process/context_provider_in_process.cc

index 3f0f341f299e0ba0d267ae8c91846ed127255045..26758fe1a2f084927528f2fc9f564f7d73cfb97b 100644

--- a/content/browser/android/in_process/context_provider_in_process.cc

+++ b/content/browser/android/in_process/context_provider_in_process.cc

@@ -100,8 +100,9 @@ bool ContextProviderInProcess::BindToCurrentThread() {

InitializeCapabilities();

- std::string unique_context_name =

+ const std::string unique_context_name =

base::StringPrintf("%s-%p", debug_name_.c_str(), context3d_.get());

+ context3d_->pushGroupMarkerEXT(unique_context_name.c_str());

vmiura 2015/05/12 21:47:41 Same, suggest keeping only traceBeginCHROMIUM vers

context3d_->traceBeginCHROMIUM("gpu_toplevel",

unique_context_name.c_str());