Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: cc/resources/scoped_gpu_raster.cc

Issue 1132283003: Merge Group Markers into Chromium Traces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed references to group markers in unit tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/scoped_gpu_raster.cc
diff --git a/cc/resources/scoped_gpu_raster.cc b/cc/resources/scoped_gpu_raster.cc
index 2f5c5c9c3426a42eca7532cb8919611884a983d1..db8e9985c2f58137539da29ee46c7d80c426e125 100644
--- a/cc/resources/scoped_gpu_raster.cc
+++ b/cc/resources/scoped_gpu_raster.cc
@@ -28,6 +28,7 @@ void ScopedGpuRaster::BeginGpuRaster() {
// Using push/pop functions directly incurs cost to evaluate function
// arguments even when tracing is disabled.
gl->PushGroupMarkerEXT(0, "GpuRasterization");
+ gl->TraceBeginCHROMIUM("GroupMarker", "GpuRasterization");
no sievers 2015/05/12 17:51:44 Why "GroupMarker"?
David Yen 2015/05/12 17:56:13 I couldn't really think of a good trace category,
class GrContext* gr_context = context_provider_->GrContext();
gr_context->resetContext();
@@ -45,6 +46,7 @@ void ScopedGpuRaster::EndGpuRaster() {
// TODO(alokp): Use a trace macro to push/pop markers.
// Using push/pop functions directly incurs cost to evaluate function
// arguments even when tracing is disabled.
+ gl->TraceEndCHROMIUM();
gl->PopGroupMarkerEXT();
}

Powered by Google App Engine
This is Rietveld 408576698