Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: cc/raster/scoped_gpu_raster.cc

Issue 1132283003: Merge Group Markers into Chromium Traces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted some unnecessary files, fixed some issues Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/scoped_gpu_raster.cc
diff --git a/cc/raster/scoped_gpu_raster.cc b/cc/raster/scoped_gpu_raster.cc
index f548515b6985084a5ef6fc7b016c3d3e4c00e727..e6dcf231ba2dcda9036566c79c34e9c2651b54aa 100644
--- a/cc/raster/scoped_gpu_raster.cc
+++ b/cc/raster/scoped_gpu_raster.cc
@@ -27,7 +27,7 @@ void ScopedGpuRaster::BeginGpuRaster() {
// TODO(alokp): Use a trace macro to push/pop markers.
// Using push/pop functions directly incurs cost to evaluate function
// arguments even when tracing is disabled.
- gl->PushGroupMarkerEXT(0, "GpuRasterization");
+ gl->TraceBeginCHROMIUM("ScopedGpuRaster", "GpuRasterization");
vmiura 2015/06/25 00:41:57 Can we put this in "gpu_toplevel" category too?
David Yen 2015/06/25 17:40:35 These are under the top level compositor marker so
class GrContext* gr_context = context_provider_->GrContext();
gr_context->resetContext();
@@ -45,7 +45,7 @@ void ScopedGpuRaster::EndGpuRaster() {
// TODO(alokp): Use a trace macro to push/pop markers.
// Using push/pop functions directly incurs cost to evaluate function
// arguments even when tracing is disabled.
- gl->PopGroupMarkerEXT();
+ gl->TraceEndCHROMIUM();
}
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698