chrome/browser/resources/settings/settings_main/settings_main.html - Issue 1132223005: Fix the pref binding by binding to the object rather than the element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes

Patch Set: ::change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings.js ('k') | ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 2ca01ef129755f089173d3b84f47e74f197e4787..3e949596b4be80fed4a609ed0bf36f0130c18635 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -42,10 +42,8 @@

</if>

<cr-settings-downloads-page prefs="{{prefs}}" route="downloads">

</cr-settings-downloads-page>

- <cr-settings-search-page prefs="{{prefs}}" route="search">

- </cr-settings-search-page>

- <cr-settings-search-engines-page prefs="{{prefs}}"

- route="search-engines">

+ <cr-settings-search-page route="search"></cr-settings-search-page>

+ <cr-settings-search-engines-page route="search-engines">

</cr-settings-search-engines-page>

</iron-pages>

</more-route-selector>

« no previous file with comments | « chrome/browser/resources/settings/settings.js ('k') | ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.js » ('j') | no next file with comments »