chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 1132223005: Fix the pref binding by binding to the object rather than the element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes

Patch Set: ::change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/date_time_page/date_time_page.js ('k') | chrome/browser/resources/settings/downloads_page/downloads_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/downloads_page/downloads_page.html

diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html

index 7da83f6e2ee7311547a662d4a61c707b672ab0f1..b270b5de5cc99464bd03aff5b8c732d9ffb8599e 100644

--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html

+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html

@@ -15,7 +15,7 @@

<cr-input id="downloadsPath" floating-label="false"

- value="{{prefs.settings.download.default_directory.value}}"

+ value="{{prefs.download.default_directory.value}}"

readonly aria-labelledby="locationLabel">

</cr-input>

</div>

@@ -24,7 +24,7 @@

</cr-button>

</div>

<cr-settings-checkbox

- pref="{{prefs.settings.download.prompt_for_download}}"

+ pref="{{prefs.download.prompt_for_download}}"

i18n-values="label:downloadsPromptForDownloadLabel">

</cr-settings-checkbox>

</paper-material>