chrome/browser/resources/settings/settings.js - Issue 1132223005: Fix the pref binding by binding to the object rather than the element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes

Patch Set: revert accidental change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/a11y_page/a11y_page.js ('K') | « chrome/browser/resources/settings/settings.html ('k') | chrome/browser/resources/settings/settings_main/settings_main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings.js

diff --git a/chrome/browser/resources/settings/settings.js b/chrome/browser/resources/settings/settings.js

index 3294f49c8de2cca6d3ccf32d239527e8d4ac8656..6995f58e39d34ef0037b46a9923dc16a0e5e495a 100644

--- a/chrome/browser/resources/settings/settings.js

+++ b/chrome/browser/resources/settings/settings.js

@@ -13,18 +13,4 @@

* @group Chrome Settings Elements

* @element cr-settings

-Polymer({

- is: 'cr-settings',

- properties: {

- /**

- * The CrSettingsPrefsElement used throughout the app.

- * @private {!CrSettingsPrefsElement}

- */

- prefs_: {

- type: Object,

- value: function() { return this.$.prefs; },

- notify: true,

- }

- },

-});

+Polymer({is: 'cr-settings'});