Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7045)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/checkbox/checkbox.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: revert accidental change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/settings/a11y_page/a11y_page.js ('K') | « chrome/browser/resources/settings/a11y_page/a11y_page.js ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/checkbox/checkbox.js
diff --git a/chrome/browser/resources/settings/checkbox/checkbox.js b/chrome/browser/resources/settings/checkbox/checkbox.js
index cb951b544fbc310b4c316a592e183e8d87ea243e..6e0860cf00b7b85554b4f9d0faabd3654c8daf14 100644
--- a/chrome/browser/resources/settings/checkbox/checkbox.js
+++ b/chrome/browser/resources/settings/checkbox/checkbox.js
@@ -21,7 +21,10 @@ Polymer({
* The boolean preference object to control.
* @type {?chrome.settingsPrivate.PrefObject}
*/
- pref: Object,
+ pref: {
+ type: Object,
+ notify: true,
+ },
label: {
type: String,
« chrome/browser/resources/settings/a11y_page/a11y_page.js ('K') | « chrome/browser/resources/settings/a11y_page/a11y_page.js ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698