Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7035)

Unified Diff: chrome/browser/resources/settings/a11y_page/a11y_page.html

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: revert accidental change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/a11y_page/a11y_page.html
diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.html b/chrome/browser/resources/settings/a11y_page/a11y_page.html
index 431d642f1edd5b105c15733326763a04331f8d17..1b3e5827be35e0adf03c0c17332519c9ec05727e 100644
--- a/chrome/browser/resources/settings/a11y_page/a11y_page.html
+++ b/chrome/browser/resources/settings/a11y_page/a11y_page.html
@@ -15,42 +15,43 @@
<if expr="chromeos">
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.enable_menu}}"
+ pref="{{prefs.settings.a11y.enable_menu}}"
i18n-values="label:accessibilityOptionsInMenuLabel">
</cr-settings-checkbox>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.large_cursor_enabled}}"
+ pref="{{prefs.settings.a11y.large_cursor_enabled}}"
i18n-values="label:accessibilityLargeMouseCursorLabel">
</cr-settings-checkbox>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.high_contrast_enabled}}"
+ pref="{{prefs.settings.a11y.high_contrast_enabled}}"
i18n-values="label:accessibilityHighContrastLabel">
</cr-settings-checkbox>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.sticky_keys_enabled}}"
+ pref="{{prefs.settings.a11y.sticky_keys_enabled}}"
i18n-values="label:accessibilityStickyKeysLabel;
subLabel:accessibilityStickyKeysSublabel">
</cr-settings-checkbox>
- <cr-settings-checkbox pref="{{prefs.settings.settings.accessibility}}"
+ <cr-settings-checkbox pref="{{prefs.settings.accessibility}}"
i18n-values="label:accessibilityChromeVoxLabel;
subLabel:accessibilityChromeVoxSublabel">
</cr-settings-checkbox>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.screen_magnifier}}"
+ pref="{{prefs.settings.a11y.screen_magnifier}}"
i18n-values="label:accessibilityScreenMagnifierLabel">
</cr-settings-checkbox>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.touchpad.enable_tap_dragging}}"
+ pref="{{prefs.settings.touchpad.enable_tap_dragging}}"
i18n-values="label:accessibilityTapDraggingLabel">
</cr-settings-checkbox>
- <cr-settings-checkbox pref="{{prefs.settings.settings.a11y.autoclick}}"
+ <cr-settings-checkbox pref="{{prefs.settings.a11y.autoclick}}"
i18n-values="label:accessibilityClickOnStopLabel">
</cr-settings-checkbox>
<div class="autoclick-delay-label"
- hidden$="{{!prefs.settings.settings.a11y.autoclick}}">
+ hidden$="{{!prefs.settings.a11y.autoclick}}">
<span i18n-content="accessibilityDelayBeforeClickLabel"></span>
- <select id="autoclickDropdown" on-change="autoclickSelectChanged_">
+ <select id="autoclickDropdown" on-change="autoclickSelectChanged_"
+ value="{{prefs.settings.a11y.autoclick_delay_ms}}">
michaelpg 2015/05/13 23:49:50 add ::change for native element
Jeremy Klein 2015/05/14 00:53:52 Totally forgot about this. Great call!
<option value="200"
i18n-content="accessibilityDelayBeforeClickExtremelyShort">
</option>
@@ -70,7 +71,7 @@
</div>
<cr-settings-checkbox
- pref="{{prefs.settings.settings.a11y.virtual_keyboard}}"
+ pref="{{prefs.settings.a11y.virtual_keyboard}}"
i18n-values="label:accessibilityOnScreenKeyboardLabel">
</cr-settings-checkbox>
</if>

Powered by Google App Engine
This is Rietveld 408576698