Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: ::change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-settings-search-page' is the settings page containing search settings. 7 * 'cr-settings-search-page' is the settings page containing search settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
11 * <iron-animated-pages> 11 * <iron-animated-pages>
12 * <cr-settings-search-page prefs="{{prefs}}"></cr-settings-search-page> 12 * <cr-settings-search-page prefs="{{prefs}}"></cr-settings-search-page>
13 * ... other pages ... 13 * ... other pages ...
14 * </iron-animated-pages> 14 * </iron-animated-pages>
15 * 15 *
16 * @group Chrome Settings Elements 16 * @group Chrome Settings Elements
17 * @element cr-settings-search-page 17 * @element cr-settings-search-page
18 */ 18 */
19 Polymer({ 19 Polymer({
20 is: 'cr-settings-search-page', 20 is: 'cr-settings-search-page',
21 21
22 properties: { 22 properties: {
23 /** 23 /**
24 * Preferences state.
25 * @type {?CrSettingsPrefsElement}
26 */
27 prefs: {
28 type: Object,
29 notify: true,
30 },
31
32 /**
33 * Route for the page. 24 * Route for the page.
34 */ 25 */
35 route: String, 26 route: String,
36 27
37 /** 28 /**
38 * Whether the page is a subpage. 29 * Whether the page is a subpage.
39 */ 30 */
40 subpage: { 31 subpage: {
41 type: Boolean, 32 type: Boolean,
42 value: false, 33 value: false,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 }, this); 105 }, this);
115 106
116 this.searchEngines = defaultEngines; 107 this.searchEngines = defaultEngines;
117 }, 108 },
118 109
119 /** @private */ 110 /** @private */
120 manageSearchEngines_: function() { 111 manageSearchEngines_: function() {
121 MoreRouting.navigateTo('search-engines'); 112 MoreRouting.navigateTo('search-engines');
122 }, 113 },
123 }); 114 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698