Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: ::change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'cr-settings-search-engines-page' is the settings page 6 * @fileoverview 'cr-settings-search-engines-page' is the settings page
7 * containing search engines settings. 7 * containing search engines settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
11 * <core-animated-pages> 11 * <core-animated-pages>
12 * <cr-settings-search-engines-page prefs="{{prefs}}"> 12 * <cr-settings-search-engines-page prefs="{{prefs}}">
13 * </cr-settings-search-engines-page> 13 * </cr-settings-search-engines-page>
14 * ... other pages ... 14 * ... other pages ...
15 * </core-animated-pages> 15 * </core-animated-pages>
16 * 16 *
17 * @group Chrome Settings Elements 17 * @group Chrome Settings Elements
18 * @element cr-settings-search-engines-page 18 * @element cr-settings-search-engines-page
19 */ 19 */
20 Polymer({ 20 Polymer({
21 is: 'cr-settings-search-engines-page', 21 is: 'cr-settings-search-engines-page',
22 22
23 properties: { 23 properties: {
24 /** 24 /**
25 * Preferences state.
26 * @type {?CrSettingsPrefsElement}
27 */
28 prefs: {
29 type: Object,
30 notify: true
31 },
32
33 /**
34 * Route for the page. 25 * Route for the page.
35 */ 26 */
36 route: { 27 route: {
37 type: String, 28 type: String,
38 value: '' 29 value: ''
39 }, 30 },
40 31
41 /** 32 /**
42 * Whether the page is a subpage. 33 * Whether the page is a subpage.
43 */ 34 */
(...skipping 24 matching lines...) Expand all
68 /** 59 /**
69 * Name of the 'core-icon' to be shown in the settings-page-header. 60 * Name of the 'core-icon' to be shown in the settings-page-header.
70 */ 61 */
71 icon: { 62 icon: {
72 type: String, 63 type: String,
73 value: 'search', 64 value: 'search',
74 readOnly: true 65 readOnly: true
75 }, 66 },
76 }, 67 },
77 }); 68 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/prefs/prefs.js ('k') | chrome/browser/resources/settings/search_page/search_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698