Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: ::change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-settings-downloads-page' is the settings page containing downloads 7 * 'cr-settings-downloads-page' is the settings page containing downloads
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
11 * 11 *
12 * <iron-animated-pages> 12 * <iron-animated-pages>
13 * <cr-settings-downloads-page prefs="{{prefs}}"> 13 * <cr-settings-downloads-page prefs="{{prefs}}">
14 * </cr-settings-downloads-page> 14 * </cr-settings-downloads-page>
15 * ... other pages ... 15 * ... other pages ...
16 * </iron-animated-pages> 16 * </iron-animated-pages>
17 * 17 *
18 * @group Chrome Settings Elements 18 * @group Chrome Settings Elements
19 * @element cr-settings-downloads-page 19 * @element cr-settings-downloads-page
20 */ 20 */
21 Polymer({ 21 Polymer({
22 is: 'cr-settings-downloads-page', 22 is: 'cr-settings-downloads-page',
23 23
24 properties: { 24 properties: {
25 /** 25 /**
26 * Preferences state. 26 * Preferences state.
27 * @type {?CrSettingsPrefsElement}
28 */ 27 */
29 prefs: { 28 prefs: {
30 type: Object, 29 type: Object,
31 notify: true, 30 notify: true,
32 }, 31 },
33 32
34 /** 33 /**
35 * Route for the page. 34 * Route for the page.
36 */ 35 */
37 route: String, 36 route: String,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 }, 73 },
75 }, 74 },
76 75
77 /** @private */ 76 /** @private */
78 selectDownloadLocation_: function() { 77 selectDownloadLocation_: function() {
79 // TODO(orenb): Communicate with the C++ to actually display a folder 78 // TODO(orenb): Communicate with the C++ to actually display a folder
80 // picker. 79 // picker.
81 this.$.downloadsPath.value = '/Downloads'; 80 this.$.downloadsPath.value = '/Downloads';
82 }, 81 },
83 }); 82 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/downloads_page/downloads_page.html ('k') | chrome/browser/resources/settings/prefs/prefs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698