Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/resources/settings/a11y_page/a11y_page.js

Issue 1132223005: Fix the pref binding by binding to the object rather than the element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: revert accidental change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-settings-a11y-page' is the settings page containing accessibility 7 * 'cr-settings-a11y-page' is the settings page containing accessibility
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
11 * 11 *
12 * <iron-animated-pages> 12 * <iron-animated-pages>
13 * <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page> 13 * <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
14 * ... other pages ... 14 * ... other pages ...
15 * </iron-animated-pages> 15 * </iron-animated-pages>
16 * 16 *
17 * @group Chrome Settings Elements 17 * @group Chrome Settings Elements
18 * @element cr-settings-a11y-page 18 * @element cr-settings-a11y-page
19 */ 19 */
20 Polymer({ 20 Polymer({
21 is: 'cr-settings-a11y-page', 21 is: 'cr-settings-a11y-page',
22 22
23 properties: { 23 properties: {
24 /** 24 /**
25 * Preferences state. 25 * Preferences state.
26 *
27 * @type {?CrSettingsPrefsElement}
28 * @default null
29 */ 26 */
30 prefs: { 27 prefs: {
31 type: Object, 28 type: Object,
32 notify: true, 29 notify: true,
33 }, 30 },
34 31
35 /** 32 /**
36 * Route for the page. 33 * Route for the page.
37 */ 34 */
38 route: String, 35 route: String,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 readOnly: true, 69 readOnly: true,
73 }, 70 },
74 }, 71 },
75 72
76 /** 73 /**
77 * Called when the selected value of the autoclick dropdown changes. 74 * Called when the selected value of the autoclick dropdown changes.
78 * TODO(jlklein): Replace with binding when paper-dropdown lands. 75 * TODO(jlklein): Replace with binding when paper-dropdown lands.
79 * @private 76 * @private
80 */ 77 */
81 autoclickSelectChanged_: function() { 78 autoclickSelectChanged_: function() {
82 this.prefs.settings.settings.a11y.autoclick_delay_ms = 79 this.prefs.settings.a11y.autoclick_delay_ms =
michaelpg 2015/05/13 23:49:50 i know I saw this before, but I think you don't ne
Jeremy Klein 2015/05/14 00:53:52 Done.
83 this.$.autoclickDropdown.value; 80 this.$.autoclickDropdown.value;
84 }, 81 },
85 }); 82 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698