Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1132223002: Sanitize data before providing it to the CDM (Closed)

Created:
5 years, 7 months ago by jrummell
Modified:
5 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sanitize data before providing it to the CDM Sanitize |session_id| passed to load() and |response| passed to update(). BUG=456398 TEST=new blink layout tests Committed: https://crrev.com/eb352102b84eacd70b14fb51566760a4077f8050 Cr-Commit-Position: refs/heads/master@{#329535}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes #

Patch Set 3 : windows change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -14 lines) Patch
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 4 chunks +82 lines, -2 lines 0 comments Download
M media/cdm/json_web_key.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cdm/json_web_key.cc View 1 1 chunk +47 lines, -9 lines 0 comments Download
M media/cdm/json_web_key_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M media/cdm/key_system_names.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M media/cdm/key_system_names.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jrummell
PTAL.
5 years, 7 months ago (2015-05-09 00:36:39 UTC) #2
sandersd (OOO until July 31)
https://codereview.chromium.org/1132223002/diff/1/media/blink/webcontentdecryptionmodulesession_impl.cc File media/blink/webcontentdecryptionmodulesession_impl.cc (right): https://codereview.chromium.org/1132223002/diff/1/media/blink/webcontentdecryptionmodulesession_impl.cc#newcode309 media/blink/webcontentdecryptionmodulesession_impl.cc:309: "Invalid session Id."); ID https://codereview.chromium.org/1132223002/diff/1/media/cdm/json_web_key.cc File media/cdm/json_web_key.cc (right): https://codereview.chromium.org/1132223002/diff/1/media/cdm/json_web_key.cc#newcode136 ...
5 years, 7 months ago (2015-05-09 01:06:57 UTC) #3
jrummell
Updated. https://codereview.chromium.org/1132223002/diff/1/media/blink/webcontentdecryptionmodulesession_impl.cc File media/blink/webcontentdecryptionmodulesession_impl.cc (right): https://codereview.chromium.org/1132223002/diff/1/media/blink/webcontentdecryptionmodulesession_impl.cc#newcode309 media/blink/webcontentdecryptionmodulesession_impl.cc:309: "Invalid session Id."); On 2015/05/09 01:06:57, sandersd wrote: ...
5 years, 7 months ago (2015-05-09 01:11:45 UTC) #4
sandersd (OOO until July 31)
lgtm
5 years, 7 months ago (2015-05-09 01:15:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132223002/20001
5 years, 7 months ago (2015-05-11 22:12:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/37800)
5 years, 7 months ago (2015-05-11 23:20:05 UTC) #9
jrummell
Updated to make Windows compile.
5 years, 7 months ago (2015-05-12 22:37:18 UTC) #10
sandersd (OOO until July 31)
Still lgtm.
5 years, 7 months ago (2015-05-12 23:05:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132223002/40001
5 years, 7 months ago (2015-05-13 00:05:45 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 00:10:38 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 00:11:38 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb352102b84eacd70b14fb51566760a4077f8050
Cr-Commit-Position: refs/heads/master@{#329535}

Powered by Google App Engine
This is Rietveld 408576698